-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overcome fastutil issue #3409
Merged
Merged
Overcome fastutil issue #3409
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,8 @@ | |
|
||
/** | ||
* A class that lives inside the root package | ||
* | ||
* <[email protected]> | ||
*/ | ||
class RootPackageClass { | ||
val description = "I do live in the root package!" | ||
|
49 changes: 49 additions & 0 deletions
49
...pi/src/test/kotlin/org/jetbrains/dokka/analysis/test/documentable/SpecialCharacterTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Copyright 2014-2023 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | ||
*/ | ||
|
||
package org.jetbrains.dokka.analysis.test.documentable | ||
|
||
import org.jetbrains.dokka.analysis.test.api.kotlinJvmTestProject | ||
import org.jetbrains.dokka.analysis.test.api.parse | ||
import org.jetbrains.dokka.model.doc.* | ||
import kotlin.test.Test | ||
import kotlin.test.assertEquals | ||
|
||
class SpecialCharacterTest { | ||
|
||
@Test | ||
fun `should be able to parse email`() { | ||
val project = kotlinJvmTestProject { | ||
ktFile("Klass.kt") { | ||
+""" | ||
/** | ||
* <[email protected]> | ||
*/ | ||
class Klass | ||
""" | ||
} | ||
} | ||
|
||
val module = project.parse() | ||
|
||
val pkg = module.packages.single() | ||
val cls = pkg.classlikes.single() | ||
|
||
assertEquals("Klass", cls.name) | ||
|
||
val text = P( | ||
listOf( | ||
Text("<", params = mapOf("content-type" to "html")), | ||
Text("[email protected]"), | ||
Text(">", params = mapOf("content-type" to "html")) | ||
) | ||
) | ||
val description = Description(CustomDocTag(listOf(text), name = "MARKDOWN_FILE")) | ||
|
||
assertEquals( | ||
DocumentationNode(listOf(description)), | ||
cls.documentation.values.single(), | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just in case, I haven't mentioned it, but this is the same version, which is used in
jetbrains-markdown
right nowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this version need to be aligned with the version of
fastutil
from some other dependency, like the version used injetbrains-markdown
or inkotlin-compiler
?If it needs to be aligned, I think there should definitely be a comment about it with a link, similar to how it's done for
intellij-platform
up above, so that we are not trigger-happy with updating itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the version should be compatible with what is used in
kotlin-compiler
(AFAIK the same version is used inIntelliJ
dependencies) and withmarkdown-jb
library.For now,
markdown-jb
uses newer version - so I would think we need to align with it.I will write additional comment here