Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several style improvements #3745

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

solonovamax
Copy link

This PR adds several improvements to the style.

  • Add more minimalist scrollbar for webkit with fallback for firefox.
  • Add purple highlight to sidebar, section tabs, and more, in dark mode for parity with light mode.
  • Massively improve quote block styling.
  • Change contrast of block quotes.
  • Add transition effect for section tab hover/select.
  • Remove codeblock overflow.
  • Increase sidebar width, add logic to prevent sidebar from being too large on smaller screens.

You can see what most of the changes look like here, however a few have been updated/have had minor changes to them since I made that plugin.

- Add more minimalist scrollbar for webkit with fallback for firefox.
- Add purple highlight to sidebar, section tabs, and more, in dark mode for parity with light mode.
- Massively improve quote block styling.
- Change contrast of block quotes.
- Add transition effect for section tab hover/select.
- Remove codeblock overflow.
- Increase sidebar width, add logic to prevent sidebar from being too large on smaller screens.

Signed-off-by: solonovamax <[email protected]>
@whyoleg
Copy link
Contributor

whyoleg commented Aug 16, 2024

Hey, thanks for the PR!
We are currently working on several improvements to our HTML format.
@berezinant could you check how it correlate with it?

@whyoleg whyoleg requested a review from berezinant August 16, 2024 09:10
@solonovamax
Copy link
Author

Hey, thanks for the PR!
We are currently working on several improvements to our HTML format.
@berezinant could you check how it correlate with it?

most of these are really minor changes for things, but if there's a branch for the new documentation format I could take a peek at it and port it to there if you'd like

@solonovamax
Copy link
Author

also, smth that could possibly be considered would be adding a compile step for scss -> css then using that css in the output. this would make it a tad bit nicer to write & organize css for dokka. I have smth similar set up in this repo, just using freefair's sass gradle plugin to compile it.

with scss I can

  • split out independent things into separate files
  • some quick utility functions to automatically add vendor prefixes
  • have the resulting css be compressed (stripped of whitespace)

though if the UI is being majorly reworked, the vast majority of the UI could be moved into its own subproject so that way it gets a compile step allowing for things like cssnano, etc. to minify it.

@solonovamax
Copy link
Author

hey, any updates on this? I'd love to see this merged, and if there is anything that needs discussing, I'd be more than happy to pop in to slack (or elsewhere) to do so.

@whyoleg
Copy link
Contributor

whyoleg commented Nov 1, 2024

Hey, let's check what could be contributed after the Dokka 2.0.0 release with HTML changes. Here is a sneak peek for the amount of changes

@solonovamax
Copy link
Author

Hey, let's check what could be contributed after the Dokka 2.0.0 release with HTML changes. Here is a sneak peek for the amount of changes

I'll clone that branch and see which changes still apply, which need to be changed, and possibly if there are any new ones to add. Then, I'll rebase my branch against that branch, to pull in those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants