Drop kotlinx.serialization compiler plugin as it's unnecessary #3899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll simplify build logic
adam-enko
reviewed
Nov 4, 2024
Comment on lines
+48
to
+53
| fun fromJsonObject(obj: JsonObject): DokkaModuleDescriptionKxs = DokkaModuleDescriptionKxs( | ||
| name = obj["name"]!!.jsonPrimitive.content, | ||
| modulePath = obj["modulePath"]!!.jsonPrimitive.content, | ||
| moduleOutputDirName = obj["moduleOutputDirName"]!!.jsonPrimitive.content, | ||
| moduleIncludesDirName = obj["moduleIncludesDirName"]!!.jsonPrimitive.content, | ||
| ) |
There was a problem hiding this comment.
This needs to be updated, because properties with default constructor arguments are optional.
What do you think about adding some tests? To ensure any code changes don't break things in the future.
adam-enko
added
the
runner: Gradle plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3898, required to be able to update to KGP 2.1.0