-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to pyproject.toml #1546
Conversation
025e7a7
to
c118c35
Compare
This change can cause issues in external packaging (e.g. RPM or DEB) which need to be potentially adjusted, postponed to 3.3.0 to avoid such potential unexpected change in a very minor version. |
c118c35
to
af03f90
Compare
when is 3.3.0 coming ? |
only code-related outstandings are this and your other PR, but these can be postponed to 3.3.x if you wish |
let's get it merged for 3.3.0 |
regarding
Would it be possible to support both methods? I do not like to introduce for RPM packaging for radicale/EL8 the same as I already did for mailmain3 (huge amount of workarounds, even for EL9 in this case). How urgent is this change to "pyproject.toml"? |
Hmm, saw now that meanwhile Python 3.11 arrived in EL8 and EL9
So in case this PR is applied, packaging for EL8+9 has to change then from Python 3.9 to 3.11 - should be not a big deal. |
what is EL8 ? |
Enterprise Linux major version 8 - Red Hat, Alma, Rocky... |
@deronnax : please rebase to latest, currently your branch has conflicts |
af03f90
to
33af457
Compare
@deronnax can you please dig into why the "lint" test failed? |
@deronnax this broke more now...can you try to run test suite locally (https://github.com/Kozea/Radicale/wiki/Development-Testing-Release#complete-test-suite) to fix this |
0f6fdbb
to
6e103b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
It's the future. The setup.cfg needs to stay because flake8 refuses to migrate to pyproject.toml. The
tox
config stays there as well, as tox config in pyproject.toml is currently basically inlined tox setup.cfg config.