Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml #1546

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

deronnax
Copy link
Contributor

@deronnax deronnax commented Jul 23, 2024

It's the future. The setup.cfg needs to stay because flake8 refuses to migrate to pyproject.toml. The tox config stays there as well, as tox config in pyproject.toml is currently basically inlined tox setup.cfg config.

@pbiering pbiering added this to the 3.3.0 milestone Jul 24, 2024
@pbiering pbiering self-requested a review July 24, 2024 05:09
@pbiering pbiering self-assigned this Jul 24, 2024
@pbiering
Copy link
Collaborator

This change can cause issues in external packaging (e.g. RPM or DEB) which need to be potentially adjusted, postponed to 3.3.0 to avoid such potential unexpected change in a very minor version.

@pbiering pbiering modified the milestones: 3.3.0, 3.3.x Sep 23, 2024
@deronnax
Copy link
Contributor Author

deronnax commented Oct 3, 2024

when is 3.3.0 coming ?

@pbiering
Copy link
Collaborator

pbiering commented Oct 3, 2024

when is 3.3.0 coming ?

only code-related outstandings are this and your other PR, but these can be postponed to 3.3.x if you wish

@deronnax
Copy link
Contributor Author

deronnax commented Oct 3, 2024

let's get it merged for 3.3.0

@pbiering
Copy link
Collaborator

pbiering commented Oct 3, 2024

regarding requires = ["setuptools>=61.2"] -> this will kill EL8 support because here the latest available version is

python39-setuptools.noarch   50.3.2-6.module_el8.10.0+3885+d986a391   @appstream

Would it be possible to support both methods? I do not like to introduce for RPM packaging for radicale/EL8 the same as I already did for mailmain3 (huge amount of workarounds, even for EL9 in this case).

How urgent is this change to "pyproject.toml"?

@pbiering
Copy link
Collaborator

pbiering commented Oct 3, 2024

regarding requires = ["setuptools>=61.2"]

Hmm, saw now that meanwhile Python 3.11 arrived in EL8 and EL9

python3.11-setuptools.noarch    65.5.1-3.el8_10    appstream  
python3.12-setuptools.noarch    68.2.2-4.el8_10    appstream  

python3.11-setuptools.noarch    65.5.1-2.el9_4.1   appstream
python3.12-setuptools.noarch    68.2.2-3.el9_4.1   appstream

So in case this PR is applied, packaging for EL8+9 has to change then from Python 3.9 to 3.11 - should be not a big deal.

@deronnax
Copy link
Contributor Author

deronnax commented Oct 3, 2024

what is EL8 ?

@pbiering
Copy link
Collaborator

pbiering commented Oct 3, 2024

what is EL8 ?

Enterprise Linux major version 8 - Red Hat, Alma, Rocky...

@pbiering
Copy link
Collaborator

pbiering commented Oct 3, 2024

@deronnax : please rebase to latest, currently your branch has conflicts

@pbiering
Copy link
Collaborator

pbiering commented Oct 4, 2024

@deronnax can you please dig into why the "lint" test failed?

@pbiering
Copy link
Collaborator

pbiering commented Oct 6, 2024

@deronnax this broke more now...can you try to run test suite locally (https://github.com/Kozea/Radicale/wiki/Development-Testing-Release#complete-test-suite) to fix this

Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@pbiering pbiering merged commit 37148b7 into Kozea:master Oct 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants