-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build macOS executable for M- series Macs #2263
base: main
Are you sure you want to change the base?
Conversation
Build macOS executable for M- series Macs
I'm not sure where the appropriate place to update documentation on using this binary would be, but I would be happy to contribute to the documentation as the team sees fit. You can see the result of the GitHub action run on my fork here. |
Hi! Thanks for this pull request. For now, we’re not sure that we want to generate and support a macOS executable. We tried with Windows, and it actually introduced a number of bugs that are hard to understand, reproduce, and fix for us. The problem is that we don’t have regular Windows or macOS testers in the team, and that nobody wants to take care of this in the long term. So, if we have a large number of users ready to try, report and fix bugs, why not, but we can’t promise anything. That being said, from a technical point of view, there’s a couple of things I don’t understand:
|
I noticed there was a GitHub Action that generated a Windows (
.exe
) executable, but nothing for macOS. This pull request adds a GitHub Action to generate an executable binary for macOS.Testing
There is a test step in the GitHub Action, so no manually testing should be necessary, however, if you'd like you can download the artifact produced from the GitHub Action run. You'll need to run
chmod +x weasyprint-macos/dist/weasyprint
in order to be able to execute, but once you do, you can run./weasyprint-macos/dist/weasyprint --info
to verify the executable is working.Use cases
This executable can be bundled with Electron or Tauri applications so PDF generation is a possibility without requiring users of the built applications to install additional resources.