Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle small-caps synthesis #2345

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Handle small-caps synthesis #2345

wants to merge 6 commits into from

Conversation

liZe
Copy link
Member

@liZe liZe commented Jan 11, 2025

Fix #123.

Capture d’écran du 2025-01-11 23-09-32

Before merging this pull request, we should:

  • add tests for all values (I only tested small-caps manually),
  • check what happens with Pango < 1.50 (because of recently added variants),
  • check what happens with fonts with real small caps,
  • optimize (if needed) the new font size calculation,
  • update documentation.

@liZe liZe added the bug Existing features not working as expected label Jan 11, 2025
@liZe
Copy link
Member Author

liZe commented Jan 12, 2025

The result is cool with fonts that include small caps:
Capture d’écran du 2025-01-12 15-31-52

@liZe liZe added this to the 64.0 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Existing features not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support font-variant: small-caps approximation
1 participant