[GeoMechanicsApplication] Adopt structural truss element with reset displacement #12531

rfaasse · 2024-07-12T07:37:40Z

📝 Description
This PR adds a new process to use the reset displacement functionality. It changes the reset_displacement test for the trusses, such that the structural truss element is used, instead of the geo truss element, which has the reset_displacement functionality in it.

🆕 Changelog

Added a new reset displacement process
Made a small fix to get the IS_RESTARTED functionality to work
Use the new reset displacement process and (already existing) IS_RESTARTED functionality in the truss reset_displacement test

We now set the initial state directly at the integration points. In this way, we have overcome the limitation of `SetInitialStateProcess`, which can only set a uniform initial state at an element.

Also used forward declarations where possible.

The test is not intended to account for geometrically nonlinear behavior.

- Use Python f-strings to build filenames in an easier way. - Avoid using an index when constructing lists. - Use `zip` to iterate two sequences simultaneously, rather than using `enumerate` and an index.

…lacement option has changed

…uctural-truss-element-with-reset-displacement

…e it only works when the IS_RESTARTED flag is true

…uctural-truss-element-with-reset-displacement

avdg81

After re-reviewing, I only have a few minor suggestions left. The work you have done here looks really nice and helps us in achieving the goal of reusing elements of the StructuralMechanicsApplication rather than having slightly modified copies of them in the GeoMechanicsApplication.

applications/GeoMechanicsApplication/custom_processes/README.md

avdg81 · 2024-07-15T14:05:11Z

applications/GeoMechanicsApplication/custom_processes/reset_displacement_process.cpp

+
+        std::vector<ConstitutiveLaw::Pointer> constitutive_laws;
+        rElement.CalculateOnIntegrationPoints(CONSTITUTIVE_LAW, constitutive_laws, mrModelPart.GetProcessInfo());
+


Shouldn't we check here whether stresses_on_integration_points and constitutive_laws have the same size and that they aren't empty? E.g.:

KRATOS_ERROR_IF(stresses_on_integration_points.size() != constitutive_laws.size()) << "Number of retrieved stress vectors does not match the number of integration points" << std::endl; KRATOS_ERROR_IF(stresses_on_integration_points.empty()) << "No stress vectors could be retrieved" << std::endl;

Agreed, added some checks

avdg81 · 2024-07-15T14:17:18Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+#include "custom_processes/reset_displacement_process.h"
+#include "geo_mechanics_fast_suite.h"
+#include <boost/numeric/ublas/assignment.hpp>
+#include <includes/deprecated_variables.h>


I'm not sure why we need to include this header? Are we sure we need to have access to deprecated variables?

No clue how it got there, might be due to the alt+enter option giving the wrong include and I missed it. Removed it now

avdg81 · 2024-07-15T15:20:38Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+    std::vector<ConstitutiveLaw::Pointer> mConstitutiveLaws        = {};
+};
+
+ModelPart& CreateModelPartWithAStubElement(Model& model)


Just to follow the Kratos Style Guide:

Suggested change

ModelPart& CreateModelPartWithAStubElement(Model& model)

ModelPart& CreateModelPartWithAStubElement(Model& rModel)

avdg81 · 2024-07-15T15:24:43Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+
+    using Element::CalculateOnIntegrationPoints;
+
+    std::vector<Vector>                   mIntegrationVectorValues = {};


Perhaps mIntegrationPointVectors is a more accurate name?

avdg81 · 2024-07-15T15:31:37Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+    dynamic_cast<StubElement&>(model_part.Elements()[1]).mIntegrationVectorValues = {
+        initial_stress_vector, initial_stress_vector, initial_stress_vector};


Alternatively, you may write this assignment as follows:

Suggested change

dynamic_cast<StubElement&>(model_part.Elements()[1]).mIntegrationVectorValues = {

initial_stress_vector, initial_stress_vector, initial_stress_vector};

dynamic_cast<StubElement&>(model_part.Elements()[1]).mIntegrationVectorValues =

std::vector<Vector>(3, initial_stress_vector);

I'll leave it up to you which one you prefer.

Yes, that looks nicer, thanks!

applications/GeoMechanicsApplication/tests/geo_truss_with_reset_displacement/README.md

rfaasse · 2024-07-16T09:12:25Z

applications/StructuralMechanicsApplication/custom_constitutive/truss_constitutive_law.cpp

@@ -141,6 +141,7 @@ void TrussConstitutiveLaw::CalculateMaterialResponsePK2(Parameters& rValues)
    Vector& stress_vector = rValues.GetStressVector();
    if (stress_vector.size() != 1) stress_vector.resize(1, false);
    stress_vector[0] = this->CalculateStressElastic(rValues);
+    AddInitialStressVectorContribution(stress_vector);


This change can be ignored as it will be redundant when the PR for structural is merged

rfaasse · 2024-07-16T09:12:31Z

applications/StructuralMechanicsApplication/custom_elements/truss_element_linear_3D2N.cpp

+    else if (rVariable == PK2_STRESS_VECTOR) {
+        ConstitutiveLaw::Parameters Values(GetGeometry(),GetProperties(),rCurrentProcessInfo);
+        Vector temp_strain = ZeroVector(1);
+        Vector temp_stress = ZeroVector(1);
+        temp_strain[0] = CalculateLinearStrain();
+        Values.SetStrainVector(temp_strain);
+        Values.SetStressVector(temp_stress);
+        mpConstitutiveLaw->CalculateMaterialResponse(Values,ConstitutiveLaw::StressMeasure_PK2);
+
+        Vector test = ZeroVector(1);
+        test[0]= temp_stress[0];
+        rOutput[0] = test;
+    }


This change can be ignored as it will be redundant when the PR for structural is merged

markelov208

Hi Richard, thank you for the nice work. I have very minor non-blocking comments.

markelov208 · 2024-07-17T14:00:44Z

applications/GeoMechanicsApplication/custom_processes/reset_displacement_process.h

+                              ResetDisplacementProcess(const ResetDisplacementProcess&) = delete;
+    ResetDisplacementProcess& operator=(const ResetDisplacementProcess&)                = delete;


Ops, is it our clang-format works like that?

Hmm this is indeed strange, good catch! It seems my CLion has some issues with the formatting. I noticed it yesterday as well, which is why I ran clang-format outside of CLion to create the clang-format PR.

I now changed the CLion settings such that it uses the clang-format executable in the LLVM folder and that seems to work correctly. Might be something to look into. For now, I'll try to reformat all the files for this PR and see if there are any other changes

markelov208 · 2024-07-17T14:30:55Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+    initial_stress_vector <<= 1.0, 2.0, 3.0, 4.0;
+
+    dynamic_cast<StubElement&>(model_part.Elements()[1]).mIntegrationPointVectors =
+        std::vector<Vector>(3, initial_stress_vector);


Would it be better to introduce constexpr for 3? As far as I understand this is a number of nodes.

Agreed that's more clear. Here, it's the number of integration points in the element, but in this case that's identical to the number of nodes indeed

…uctural-truss-element-with-reset-displacement

rfaasse · 2024-09-17T15:51:46Z

applications/GeoMechanicsApplication/custom_processes/reset_displacement_process.cpp

+        for (auto i = std::size_t{0}; i < constitutive_laws.size(); ++i) {
+            auto p_initial_state = make_intrusive<InitialState>();
+            p_initial_state->SetInitialStressVector(stresses_on_integration_points[i]);
+            p_initial_state->SetInitialStrainVector(Vector{ZeroVector{stresses_on_integration_points[i].size()}});


This is the line that fixed the test, I'd like to discuss if this is correct and also whether we accept that if we don't add this strain, there is a hard crash (however, avoiding this probably means we need changes in structural, or even core.

rfaasse · 2024-09-26T07:38:16Z

applications/GeoMechanicsApplication/custom_processes/reset_displacement_process.cpp

+{
+    block_for_each(mrModelPart.Elements(), [this](Element& rElement) {
+        std::vector<Vector> stresses_on_integration_points;
+        rElement.CalculateOnIntegrationPoints(PK2_STRESS_VECTOR, stresses_on_integration_points,


As discussed, for now the PK2_STRESS_VECTOR is the right choice for structural elements (please correct me if I'm wrong @WPK4FEM)

WPK4FEM

Thank you for enabling use of the structural truss with reset displacement in GeoMechanical analysis. Some minor remarks about documentation and test naming.

WPK4FEM · 2024-09-26T08:58:07Z

applications/GeoMechanicsApplication/custom_processes/README.md

+For this process to work, the following requirements have to be met:
+1. The elements in the model part that the process is applied to should have an implementation for `CalculateOnIntegrationPoints` that calculates the PK2_STRESS_VECTOR as well as an overload of `CalculateOnIntegrationPoints` that returns a list of ConstitutiveLaw::Pointer objects for each integration point.
+2. The input type of the model can only be "rest", to ensure that the state of the model is retained from the previous stage.
+3. The ConstitutiveLaw used in the elements this process is applied to should use the `InitialState` to apply the initial stresses to the calculated stresses.


Are the initial strains ( or strain like variables ) independent of this?

I have to define something for the initial strains, since if they aren't defined, we get a hard crash (the issue we saw after bringing this branch up to date with master). At this moment, I hardcode the initial strains to be zero vectors. We could discuss if this is always the desired behavior.

WPK4FEM · 2024-09-26T09:03:00Z

applications/GeoMechanicsApplication/custom_processes/reset_displacement_process.cpp

+{
+    block_for_each(mrModelPart.Elements(), [this](Element& rElement) {
+        std::vector<Vector> stresses_on_integration_points;
+        rElement.CalculateOnIntegrationPoints(PK2_STRESS_VECTOR, stresses_on_integration_points,


WPK4FEM · 2024-09-26T09:05:33Z

applications/GeoMechanicsApplication/custom_processes/README.md

+### Requirements
+For this process to work, the following requirements have to be met:
+1. The elements in the model part that the process is applied to should have an implementation for `CalculateOnIntegrationPoints` that calculates the PK2_STRESS_VECTOR as well as an overload of `CalculateOnIntegrationPoints` that returns a list of ConstitutiveLaw::Pointer objects for each integration point.
+2. The input type of the model can only be "rest", to ensure that the state of the model is retained from the previous stage.


Maybe make clear that "rest" is short for restarted. Its further meaning is already clear from the further contents of the sentence.

Added some elaboration

WPK4FEM · 2024-09-26T11:02:59Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+    KRATOS_EXPECT_EXCEPTION_IS_THROWN(process.ExecuteInitialize(),
+                                      "Number of retrieved stress vectors does not match the "
+                                      "number of constitutive laws for element 1")
+}


When finding out what is wrong from error messages I'm often happy if information about the numbers is given, such that I have an indication which of the 2 is the wrong one.

Good suggestion, added!

WPK4FEM · 2024-09-26T11:06:58Z

...eoMechanicsApplication/tests/geo_truss_with_reset_displacement/ProjectParameters_stage1.json

@@ -13,7 +13,7 @@
        "domain_size":                        2,
        "model_import_settings":              {
            "input_type":       "mdpa",
-            "input_filename":   "geo_truss_with_reset_displacement_stage_1"
+            "input_filename":   "geo_truss_with_reset_displacement"


This name and the directory name of the test are now misleading. We are using the truss element from structural. That was the intention of the whole exercise.

Good catch, changed

WPK4FEM · 2024-09-26T11:09:36Z

applications/GeoMechanicsApplication/python_scripts/geomechanics_solver.py

@@ -205,6 +207,15 @@ def PrepareModelPart(self):
                                                  self.settings["nodal_smoothing"].GetBool())

        self.main_model_part.ProcessInfo.SetValue(KratosMultiphysics.STEP, 0)
+        self.computing_model_part_name = "porous_computational_model_part"
+
+        # Create list of sub sub model parts (it is a copy of the standard lists with a different name)


The comment had me wondering, but it does not really add information. Removing will prevent that it becomes wrong comment.

WPK4FEM · 2024-09-26T11:22:27Z

applications/GeoMechanicsApplication/python_scripts/geomechanics_solver.py

        if not self.main_model_part.ProcessInfo[KratosMultiphysics.IS_RESTARTED]:
            ## Executes the check and prepare model process (Create computing_model_part and set constitutive law)
            self._ExecuteCheckAndPrepare()


This is the switch that is important ( retain the previous constitutive law for a while ). Please explain that in the readme file.

Added it to the readme, please let me know if it's clear

avdg81

This looks like a very nice and clean extension. I have several comments, but none of them is blocking.

avdg81 · 2024-09-26T15:27:57Z

...csApplication/tests/geo_truss_with_reset_displacement/geo_truss_with_reset_displacement.mdpa

Perhaps we should rename this file, since it no longer uses "geo" truss elements...?

Similarly, we may want to rename the test directory to, e.g. truss_with_reset_displacement.

avdg81 · 2024-09-27T07:19:22Z

...eoMechanicsApplication/tests/geo_truss_with_reset_displacement/ProjectParameters_stage4.json

-            "input_type":       "mdpa",
-            "input_filename":   "geo_truss_with_reset_displacement_stage_4"
+            "input_type":       "rest",
+            "input_filename":   ""


I believe we can remove the key-value pair "input_filename", since "input_type" has been changed to "rest".

This comment also applies to the ProjectParameters.json files of stages 2 and 3.

Correct, still passes, good catch

avdg81 · 2024-09-27T07:30:42Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

Perhaps we can move this file into a subdirectory named custom_processes...?

avdg81 · 2024-09-27T07:37:06Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+#include "custom_processes/reset_displacement_process.h"
+#include "geo_mechanics_fast_suite.h"


We may consider to add a few more explicit #includes here, instead of relying on having them available indirectly through other includes. This will make the build less fragile when we start to remove unnecessary #includes from other header files. I would suggest to at least include includes/constitutive_law.h and includes/element.h, since you define here two classes (StubConstitutiveLaw and StubElement) that derive from classes that are defined in those header files. But you may want to look further to see whether we need to add even more #includes.

Done, it became quite a list when being specific :)

avdg81 · 2024-09-27T07:40:02Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+    void CalculateOnIntegrationPoints(const Variable<ConstitutiveLaw::Pointer>& rVariable,
+                                      std::vector<ConstitutiveLaw::Pointer>&    rOutput,
+                                      const ProcessInfo& rCurrentProcessInfo) override


I would suggest to "unname" rVariable and rCurrentProcessInfo, since you are not using these parameters. By having them unnamed, that is clear without checking the function body.

This suggestion also applies to the next override of CalculateOnIntegrationPoints.

avdg81 · 2024-09-27T08:23:16Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+KRATOS_TEST_CASE_IN_SUITE(ResetDisplacementProcess_SetsInitialStressOfConstitutiveLaws,
+                          KratosGeoMechanicsFastSuiteWithoutKernel)


The test code doesn't reveal how the ResetDisplacementProcess uses an Element instance to set the initial stress. The implementation of StubElement suggests that any variable will work, but that is for sure not the case (the implementation shows that variable PK2_STRESS_VECTOR is used for that). So I'm wondering whether we should make StubElement more explicit about this (i.e. force it to only accept PK2_STRESS_VECTOR)?

I was a bit in two minds here: on the one hand, I don't want to couple the tests to implementation details (e.g. I don't want to change the test when we would decide to use cauchy stress,. However, from a 'test as documentation' point of view, it might help to see here that it is required that the element can return the PK2_STRESS_VECTOR.

Since we now use SetValuesOnIntegrationPoints and have to input a stress measure there anyway, I think it's best to just be explicit, but I think it's still something to keep in mind, to not have the tests depend on implementation details

avdg81 · 2024-09-27T09:01:35Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+    dynamic_cast<StubElement&>(model_part.Elements()[1]).mIntegrationPointVectors =
+        std::vector<Vector>(number_of_integration_points, initial_stress_vector);
+
+    ResetDisplacementProcess reset_displacement_process(model_part, {});


Shall we give the second parameter a name (e.g. dummy_parameters), to make clear what it represents?

This suggestion applies to some other tests as well.

Added names to the dummy's

avdg81 · 2024-09-27T09:03:25Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+    initial_stress_vector <<= 1.0, 2.0, 3.0, 4.0;
+
+    constexpr auto number_of_integration_points = 3;
+    dynamic_cast<StubElement&>(model_part.Elements()[1]).mIntegrationPointVectors =


I don't really like the dynamic_cast here, but I don't have a better suggestion yet. I see this approach elsewhere too. Perhaps we can talk about this later, to see whether we can find a better way.

Fixed using your suggestion of SetValuesOnIntegrationPoints

avdg81 · 2024-09-27T09:57:24Z

applications/GeoMechanicsApplication/custom_processes/reset_displacement_process.cpp

+
+void ResetDisplacementProcess::CheckRetrievedElementData(const std::vector<ConstitutiveLaw::Pointer>& rConstitutiveLaws,
+                                                         const std::vector<Vector>& rStressesOnIntegrationPoints,
+                                                         const Element& rElement)


We may consider to pass the element ID here, instead of the complete element, since that is the only piece of information that we need.

Good catch, done

avdg81 · 2024-09-27T10:01:23Z

applications/GeoMechanicsApplication/tests/test_reset_displacement.py

-            displacement_stages[idx] = test_helper.get_displacement(stage)
-            nodal_coordinates_stages[idx] = test_helper. get_nodal_coordinates(stage)
+            displacement_stages.append(test_helper.get_displacement(stage))
+            nodal_coordinates_stages.append(test_helper. get_nodal_coordinates(stage))


Redundant space:

Suggested change

nodal_coordinates_stages.append(test_helper. get_nodal_coordinates(stage))

nodal_coordinates_stages.append(test_helper.get_nodal_coordinates(stage))

…ests folder

rfaasse

Thanks for the thorough reviews, I processed the comments, let me know if there's anything else!

rfaasse · 2024-09-27T11:58:44Z

applications/GeoMechanicsApplication/custom_processes/README.md

+### Requirements
+For this process to work, the following requirements have to be met:
+1. The elements in the model part that the process is applied to should have an implementation for `CalculateOnIntegrationPoints` that calculates the PK2_STRESS_VECTOR as well as an overload of `CalculateOnIntegrationPoints` that returns a list of ConstitutiveLaw::Pointer objects for each integration point.
+2. The input type of the model can only be "rest", to ensure that the state of the model is retained from the previous stage.


Added some elaboration

rfaasse · 2024-09-27T11:59:48Z

applications/GeoMechanicsApplication/custom_processes/README.md

+For this process to work, the following requirements have to be met:
+1. The elements in the model part that the process is applied to should have an implementation for `CalculateOnIntegrationPoints` that calculates the PK2_STRESS_VECTOR as well as an overload of `CalculateOnIntegrationPoints` that returns a list of ConstitutiveLaw::Pointer objects for each integration point.
+2. The input type of the model can only be "rest", to ensure that the state of the model is retained from the previous stage.
+3. The ConstitutiveLaw used in the elements this process is applied to should use the `InitialState` to apply the initial stresses to the calculated stresses.


I have to define something for the initial strains, since if they aren't defined, we get a hard crash (the issue we saw after bringing this branch up to date with master). At this moment, I hardcode the initial strains to be zero vectors. We could discuss if this is always the desired behavior.

rfaasse · 2024-09-27T12:04:36Z

applications/GeoMechanicsApplication/custom_processes/reset_displacement_process.cpp

+
+void ResetDisplacementProcess::CheckRetrievedElementData(const std::vector<ConstitutiveLaw::Pointer>& rConstitutiveLaws,
+                                                         const std::vector<Vector>& rStressesOnIntegrationPoints,
+                                                         const Element& rElement)


Good catch, done

rfaasse · 2024-09-27T12:04:42Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

rfaasse · 2024-09-27T13:23:31Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_reset_displacement_process.cpp

+#include "custom_processes/reset_displacement_process.h"
+#include "geo_mechanics_fast_suite.h"


Done, it became quite a list when being specific :)

rfaasse · 2024-09-27T13:48:29Z

applications/GeoMechanicsApplication/python_scripts/geomechanics_solver.py

@@ -205,6 +207,15 @@ def PrepareModelPart(self):
                                                  self.settings["nodal_smoothing"].GetBool())

        self.main_model_part.ProcessInfo.SetValue(KratosMultiphysics.STEP, 0)
+        self.computing_model_part_name = "porous_computational_model_part"
+
+        # Create list of sub sub model parts (it is a copy of the standard lists with a different name)


rfaasse · 2024-09-27T13:49:13Z

applications/GeoMechanicsApplication/python_scripts/geomechanics_solver.py

        if not self.main_model_part.ProcessInfo[KratosMultiphysics.IS_RESTARTED]:
            ## Executes the check and prepare model process (Create computing_model_part and set constitutive law)
            self._ExecuteCheckAndPrepare()


Added it to the readme, please let me know if it's clear

rfaasse · 2024-09-27T13:50:11Z

...eoMechanicsApplication/tests/geo_truss_with_reset_displacement/ProjectParameters_stage4.json

-            "input_type":       "mdpa",
-            "input_filename":   "geo_truss_with_reset_displacement_stage_4"
+            "input_type":       "rest",
+            "input_filename":   ""


Correct, still passes, good catch

rfaasse · 2024-09-27T13:50:15Z

...csApplication/tests/geo_truss_with_reset_displacement/geo_truss_with_reset_displacement.mdpa

rfaasse · 2024-09-27T13:51:05Z

applications/GeoMechanicsApplication/tests/test_reset_displacement.py

-            displacement_stages[idx] = test_helper.get_displacement(stage)
-            nodal_coordinates_stages[idx] = test_helper. get_nodal_coordinates(stage)
+            displacement_stages.append(test_helper.get_displacement(stage))
+            nodal_coordinates_stages.append(test_helper. get_nodal_coordinates(stage))


avdg81

I think this one is good to go.

WPK4FEM

Looks consistent. Good to go for me.

rfaasse and others added 10 commits July 10, 2024 08:50

Changed geo struss element to structural truss element

de688de

Added the experimental reset displacement process

c761c43

Cleaned truss constitutive matrix

aff7e42

Reformatted a header file using clang-format

738fe5f

Replaced using SetInitialStateProcess by a more generic approach

26487fb

We now set the initial state directly at the integration points. In this way, we have overcome the limitation of `SetInitialStateProcess`, which can only set a uniform initial state at an element.

Cleaned up the list of #includes for ResetDisplacementProcess

67b861d

Also used forward declarations where possible.

Replaced two for loops by list comprehensions

bc04d72

No longer update the nodal positions using the displacement field

4e3a1b9

The test is not intended to account for geometrically nonlinear behavior.

Refactored the reset parameters test code

a41948a

- Use Python f-strings to build filenames in an easier way. - Avoid using an index when constructing lists. - Use `zip` to iterate two sequences simultaneously, rather than using `enumerate` and an index.

Attempt at fixing test run on TC

5fe7582

rfaasse linked an issue Jul 12, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Adopt truss element 'reset displacement' approach with structural elements #12496

Closed

rfaasse added 7 commits July 12, 2024 16:38

Removed redundant mdpa files

e24927d

Renamed mdpa, since it holds for all stages now

f5146fc

Changed the README of the test, since the way of doing the reset disp…

c2f6e8f

…lacement option has changed

Added some details to the README.md of the custom_processes

c7ca4f6

Merge remote-tracking branch 'origin/master' into geo/12496-adopt-str…

fc3efcf

…uctural-truss-element-with-reset-displacement

Added unit tests for the new process and added a check function, sinc…

1e3aeba

…e it only works when the IS_RESTARTED flag is true

Merge remote-tracking branch 'origin/master' into geo/12496-adopt-str…

5cf54c1

…uctural-truss-element-with-reset-displacement

avdg81 reviewed Jul 16, 2024

View reviewed changes

Processing review comments

8d97f3b

rfaasse commented Jul 16, 2024

View reviewed changes

rfaasse requested a review from markelov208 July 16, 2024 09:17

markelov208 previously approved these changes Jul 17, 2024

View reviewed changes

Processing review comments

8464a53

rfaasse dismissed markelov208’s stale review via 8464a53 July 18, 2024 11:34

rfaasse added 2 commits September 5, 2024 16:26

Merge remote-tracking branch 'origin/master' into geo/12496-adopt-str…

394bf15

…uctural-truss-element-with-reset-displacement

Fixed the truss reset displacement test

e3fc32e

rfaasse marked this pull request as ready for review September 17, 2024 15:47

rfaasse commented Sep 17, 2024

View reviewed changes

Minor clean-up

00a92dc

rfaasse requested review from avdg81 and markelov208 September 26, 2024 07:35

rfaasse commented Sep 26, 2024

View reviewed changes

rfaasse requested a review from WPK4FEM September 26, 2024 07:38

WPK4FEM reviewed Sep 26, 2024

View reviewed changes

avdg81 reviewed Sep 27, 2024

View reviewed changes

rfaasse added 2 commits September 27, 2024 13:42

Moved reset displacement test to new custom_processes folder in cpp_t…

ef86dd0

…ests folder

Processing review comments

c316255

rfaasse commented Sep 27, 2024

View reviewed changes

rfaasse requested review from avdg81 and WPK4FEM September 27, 2024 13:56

avdg81 approved these changes Sep 27, 2024

View reviewed changes

avdg81 mentioned this pull request Sep 30, 2024

[GeoMechanicsApplication] Add multi-stage tests for the new line interface elements #12705

Draft

WPK4FEM approved these changes Sep 30, 2024

View reviewed changes

rfaasse merged commit ebea8be into master Sep 30, 2024
9 of 11 checks passed

rfaasse deleted the geo/12496-adopt-structural-truss-element-with-reset-displacement branch September 30, 2024 09:20


		std::vector<ConstitutiveLaw::Pointer> constitutive_laws;
		rElement.CalculateOnIntegrationPoints(CONSTITUTIVE_LAW, constitutive_laws, mrModelPart.GetProcessInfo());

	ModelPart& CreateModelPartWithAStubElement(Model& model)
	ModelPart& CreateModelPartWithAStubElement(Model& rModel)


		using Element::CalculateOnIntegrationPoints;

		std::vector<Vector> mIntegrationVectorValues = {};

		dynamic_cast<StubElement&>(model_part.Elements()[1]).mIntegrationVectorValues = {
		initial_stress_vector, initial_stress_vector, initial_stress_vector};

		ResetDisplacementProcess(const ResetDisplacementProcess&) = delete;
		ResetDisplacementProcess& operator=(const ResetDisplacementProcess&) = delete;

		#include "custom_processes/reset_displacement_process.h"
		#include "geo_mechanics_fast_suite.h"

		KRATOS_TEST_CASE_IN_SUITE(ResetDisplacementProcess_SetsInitialStressOfConstitutiveLaws,
		KratosGeoMechanicsFastSuiteWithoutKernel)

	nodal_coordinates_stages.append(test_helper. get_nodal_coordinates(stage))
	nodal_coordinates_stages.append(test_helper.get_nodal_coordinates(stage))

[GeoMechanicsApplication] Adopt structural truss element with reset displacement #12531

[GeoMechanicsApplication] Adopt structural truss element with reset displacement #12531

Conversation

rfaasse commented Jul 12, 2024 • edited Loading

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rfaasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

rfaasse commented Jul 12, 2024 •

edited

Loading