Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Remove the "solution_type" = "K0-procedure" #12701

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markelov208
Copy link
Contributor

📝 Description
A brief description of the PR.

  • Replaced the "solution_type" = "K0-procedure" by "quasi_static" in the project parameters .json files
  • Removeed the possibility from geomechanics_UPw_solver.py.

Copy link
Contributor

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clean-up, there seems to be one more branch in the solver where it checks for 'k0-procedure', other than that I think it's ready to go!

Comment on lines -190 to -196
elif (solution_type.lower() == "k0-procedure" or solution_type.lower() == "k0_procedure"):
if (rayleigh_m < 1.0e-20 and rayleigh_k < 1.0e-20):
KratosMultiphysics.Logger.PrintInfo("GeoMechanics_U_Pw_Solver, scheme", "Quasi-UnDamped.")
scheme = KratosGeo.NewmarkQuasistaticUPwScheme(beta,gamma,theta)
else:
KratosMultiphysics.Logger.PrintInfo("GeoMechanics_U_Pw_Solver, scheme", "Quasi-Damped.")
scheme = KratosGeo.NewmarkQuasistaticDampedUPwScheme(beta,gamma,theta)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is another k0-procedure in line 196 (for the other scheme), I'd suggest to remove that one as well

Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent. I think these were all appearances of the solution_type K0_procedure.
Good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Remove the "solution_type" = "K0-procedure"
3 participants