Frontend Offer Callback Pattern #102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
|
|
||
| const unequipAsset = (event: React.MouseEvent<HTMLButtonElement>) => { | ||
| event.stopPropagation(); | ||
| setShowToast(true); | ||
| unequipItem.mutate({ item }); | ||
| unequipItem.mutate({ item, callback: handleOfferResultBuilder(undefined, undefined, () => console.log("YURR")) }); |
There was a problem hiding this comment.
haha migth want remove the log
| } | ||
|
|
||
| export interface HandleOfferResultBuilder { | ||
| errorCallbackFunction?: (data: string, ...rest: any[]) => any; |
There was a problem hiding this comment.
no need to add "Function" to the property names, in fact I'd say we don't even need to add "Callback". Keeping variable names lean can make code more readable, in this case I'd go for something like:
interface HandleOfferResult {
error: ,
refund: ,
success: ,
}| getHandleOfferResult: () => HandleOfferResult; | ||
| } | ||
|
|
||
| export interface HandleOfferResultBuilderFunction { |
There was a problem hiding this comment.
is this not inferred from the function definition?
| @@ -19,7 +20,7 @@ export const CharacterSell = () => { | |||
|
|
|||
| const sendOfferHandler = async (data: SellData) => { | |||
| if (data.price < 1) return; // We don't want to sell for free in case someone managed to fool the frontend | |||
| await sellCharacter.callback(data.price, () => setIsPlacedInShop(true)); | |||
| await sellCharacter.callback(data.price, handleOfferResultBuilder(), () => setIsPlacedInShop(true)); | |||
There was a problem hiding this comment.
that setIsPlacedInShop bit should be part of the success callback
| @@ -15,7 +16,7 @@ export const ItemSell = () => { | |||
|
|
|||
| const sendOfferHandler = async (data: SellData) => { | |||
| if (data.price < 1) return; // We don't want to sell for free in case someone managed to fool the frontend | |||
| await sellItem.callback(data.price, () => setIsPlacedInShop(true) ); | |||
| await sellItem.callback(data.price, () => setIsPlacedInShop(true), handleOfferResultBuilder()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR:
Created a new pattern for creating offer callbacks that get passed the the wallet's
makeOfferfunction. The pattern defined incontract-callbacks.tsallows developers to define their callback functions in the view components themselves. Also, having passed the callback from the view component to the hooks you are able to overwrite the callback and add common logic to them (see for examplesevice/character.tsuseBuyCharacterhook).