Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kn/x #35

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Kn/x #35

merged 2 commits into from
Jan 18, 2025

Conversation

exdysa
Copy link
Collaborator

@exdysa exdysa commented Jan 18, 2025

Dynamic handling of type dependencies, metadata adjustments for comfyui edge cases, split of several functions, corrected tests

…ui edge cases, split of several functions, even more tests
…ui edge cases, split of several functions, corrected tests
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
except KeyError as error_log:
nfo("%s", "No key found.", error_log)
return {"": UpField.PLACEHOLDER, " ": UpField.PLACEHOLDER}
return pack_prompt(sorted_header_data), {k: v for k, v in sorted_header_data.items() if k not in NodeNames.PROMPT_LABELS and k not in NodeNames.PROMPT_NODE_FIELDS}

Check warning

Code scanning / Prospector (reported by Codacy)

line too long (167 > 159 characters) (E501) Warning

line too long (167 > 159 characters) (E501)
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
if float(python_version_tuple()[0]) == 3.0 and float(python_version_tuple()[1]) <= 12.0:
from typing_extensions import TypedDict, Annotated, List, Union
else:
from typing import TypedDict, Annotated, List, Union

Check warning

Code scanning / Pylint (reported by Codacy)

No name 'Annotated' in module 'typing' Warning

No name 'Annotated' in module 'typing'
if float(python_version_tuple()[0]) == 3.0 and float(python_version_tuple()[1]) <= 12.0:
from typing_extensions import TypedDict, Annotated, List, Union
else:
from typing import TypedDict, Annotated, List, Union

Check warning

Code scanning / Pylint (reported by Codacy)

No name 'TypedDict' in module 'typing' Warning

No name 'TypedDict' in module 'typing'
dataset_tools/correct_types.py Dismissed Show dismissed Hide dismissed
inputs: Union[dict, float]


class NodeWorkflow(TypedDict):

Check warning

Code scanning / Pylint (reported by Codacy)

Missing class docstring Warning

Missing class docstring
@@ -82,9 +82,9 @@
return wrapper


def debug_message(message, *args):
logger.debug("%s", f"{message} {args}")
def debug_message(*args):

Check warning

Code scanning / Pylint (reported by Codacy)

Missing function docstring Warning

Missing function docstring
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
tests/test_md_ps.py Dismissed Show dismissed Hide dismissed
@duskfallcrew duskfallcrew self-requested a review January 18, 2025 23:16
@duskfallcrew duskfallcrew self-assigned this Jan 18, 2025
@duskfallcrew duskfallcrew added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 18, 2025
@duskfallcrew
Copy link
Collaborator

Eh apart from codeQL being a little stingy, looks good!
I'll have a test out later on!

@duskfallcrew duskfallcrew merged commit df3b784 into main Jan 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants