Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch probes in dnsrecord reconciler #294

Closed
maksymvavilov opened this issue Nov 7, 2024 · 0 comments · Fixed by #308 or #315
Closed

Watch probes in dnsrecord reconciler #294

maksymvavilov opened this issue Nov 7, 2024 · 0 comments · Fixed by #308 or #315
Assignees

Comments

@maksymvavilov
Copy link
Contributor

What

We have the concept of exponential confidence in the reconciliation of the DNS records. With the healtchecks we will have a situation where a long-lived CR with the longest requeue time can take a significant time to react to the health probe status change.

How

We can watch probe CR in the DNS record reconciler to have it trigger premature reconciliation. The logic safeguarding from it should be changed to allow for a full reconciliation loop on the health status change to a new value (false into false or true into true should NOT trigger). After this, the confidence should be set to minimal. Additionally, we should review how and what we write to the probe CRs to make sure we aren't triggering DNS Record reconciliation on the execution of each probe.

@maleck13 maleck13 self-assigned this Nov 8, 2024
@maleck13 maleck13 moved this to In Progress in Kuadrant Nov 8, 2024
@maksymvavilov maksymvavilov moved this from Ready For Review to In Progress in Kuadrant Nov 19, 2024
@maksymvavilov maksymvavilov moved this from In Progress to Ready For Review in Kuadrant Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Nov 22, 2024
@maksymvavilov maksymvavilov linked a pull request Nov 25, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue Nov 25, 2024
probes unhealthy only if threshold exeeded
github-merge-queue bot pushed a commit that referenced this issue Nov 26, 2024
reconcile premature on probes nil -> healthy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
2 participants