Bug: ensure we watch health probes in dnsrecord controller #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymvavilov
force-pushed
the
gh-264
branch
2 times, most recently
from
6fe3e24 to
8430c7c
Compare
maleck13
reviewed
Nov 19, 2024
maleck13
reviewed
Nov 19, 2024
| logger.V(1).Info("unexpected object type", "error", fmt.Sprintf("%T is not a *v1alpha1.DNSHealthCheckProbe", o)) | ||
| } | ||
|
|
||
| records := &v1alpha1.DNSRecordList{} |
There was a problem hiding this comment.
I think here we could do a get based on the owner ref on the probe? We only have one probe here and that probe can only belong to one record right? So :
- get fresh copy probe from cluster
- check status healthy against the one received in the watch function
- If different than the fresh copy, get dnsrecord based on ownerref of probe and requeue?
There was a problem hiding this comment.
Not fetching records in the watch at all now. Using owner reference for it
maleck13
reviewed
Nov 19, 2024
maleck13
reviewed
Nov 19, 2024
| @@ -446,7 +505,7 @@ func setStatusConditions(record *v1alpha1.DNSRecord, hadChanges bool, notHealthy | |||
| setDNSRecordCondition(record, string(v1alpha1.ConditionTypeReady), metav1.ConditionTrue, string(v1alpha1.ConditionReasonProviderSuccess), "Provider ensured the dns record") | |||
|
|
|||
| // probes are disabled or not defined, or this is a wildcard record | |||
| if record.Spec.HealthCheck == nil || strings.HasPrefix(record.Spec.RootHost, v1alpha1.WildcardPrefix) { | |||
| if record.Spec.HealthCheck == nil || strings.HasPrefix(record.Spec.RootHost, v1alpha1.WildcardPrefix) || !probesEnabled { | |||
There was a problem hiding this comment.
starting to think we might remove the probes enabled flag soon
maleck13
changed the title
maksymvavilov
force-pushed
the
gh-264
branch
from
8430c7c to
2cc4821
Compare
maksymvavilov
commented
Nov 21, 2024
maleck13
reviewed
Nov 22, 2024
| } | ||
|
|
||
| probes := &v1alpha1.DNSHealthCheckProbeList{} |
There was a problem hiding this comment.
if we defined this early would it help with readability. IE jusst pass in the empty list of probes to updateStatus? as passing in nil is a bit obscure
There was a problem hiding this comment.
defined up top and passing it always into the update status func
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov
force-pushed
the
gh-264
branch
from
2cc4821 to
62a73b7
Compare
maleck13
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Looks good tried a few scenrios DNSRecord and Policy ended up as expectd
status:
conditions:
- lastTransitionTime: "2024-11-20T07:14:32Z"
message: DNSPolicy has been accepted
reason: Accepted
status: "True"
type: Accepted
- lastTransitionTime: "2024-11-21T08:15:08Z"
message: DNSPolicy has been successfully enforced
reason: Enforced
status: "True"
type: Enforced
- lastTransitionTime: "2024-11-22T11:20:05Z"
message: 'DNSPolicy has encountered some issues: not all sub-resources of policy
are passing the policy defined health check. Not healthy DNSRecords are: external-t1c
external-t1d '
reason: Unknown
status: "False"
type: SubResourcesHealthy
observedGeneration: 1
recordConditions:
t1c.cb.hcpapps.net:
- lastTransitionTime: "2024-11-22T11:20:03Z"
message: 'Not healthy addresses: [af2b62688c5454c35a1827a82e7d7c68-1089732621.eu-west-1.elb.amazonaws.com]'
observedGeneration: 1
reason: HealthChecksFailed
status: "False"
type: Healthy
t1d.cb.hcpapps.net:
- lastTransitionTime: "2024-11-22T11:20:03Z"
message: 'Not healthy addresses: [af2b62688c5454c35a1827a82e7d7c68-1089732621.eu-west-1.elb.amazonaws.com]'
observedGeneration: 1
reason: HealthChecksFailed
status: "False"
type: Healthy
totalRecords: 2
status:
conditions:
- lastTransitionTime: "2024-11-20T07:14:32Z"
message: DNSPolicy has been accepted
reason: Accepted
status: "True"
type: Accepted
- lastTransitionTime: "2024-11-21T08:15:08Z"
message: DNSPolicy has been successfully enforced
reason: Enforced
status: "True"
type: Enforced
- lastTransitionTime: "2024-11-22T14:06:42Z"
message: All sub-resources are healthy
reason: SubResourcesHealthy
status: "True"
type: SubResourcesHealthy
observedGeneration: 1
totalRecords: 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
receivedPrematurelyto consult a list of probes (and not to retrieve probes twice I'm not passing them around)probes-enabledflag set to true we now will ignore healthcheck spec. Before we would be waiting for probes to be created (they will not be created)