fix: Azure provider error parsing #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue in the cleanup of azure error messages that could cause a panic. Signed-off-by: Michael Nairn <[email protected]>
mikenairn
commented
Nov 22, 2024
| if msgBits = strings.Split(msgBits[1], `"`); len(msgBits) > 1 { | ||
| msg = msgBits[1] | ||
| } | ||
| } |
There was a problem hiding this comment.
This whole thing could probably be better done with regular expressions and groupings, but i want to avoid a bigger change here.
mikenairn
commented
Nov 22, 2024
| Expect(err).ToNot(BeNil()) | ||
| Expect(err.Error()).To(Equal("")) | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Currently it will just return an empty error if it fails the cleanup of the error. It does feel like it should probably just return the unmodified error "some other error" but the point of the cleanup is to avoid request specific data included in the error getting added into the status of the DNSRecord and causing constant updates.
|
The Azure tests don't run automatically on PRs, triggered a separate job for it here to verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue in the cleanup of azure error messages that could cause a panic.
fixes #311