Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enum Support & Nested Sort / Filter #35

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Enum Support & Nested Sort / Filter #35

wants to merge 5 commits into from

Conversation

Feramor
Copy link

@Feramor Feramor commented Feb 12, 2023

No description provided.

Münir Ozan Topcu added 3 commits February 12, 2023 12:34
Enum Support & Nested Sort / Filter
978ec92
Bump Nuget Packs
1804d7e 
Newtonsoft.Json To 13.0.2 & System.Linq.Dynamic.Core To 1.2.25
Publish Profiles
d9079f4
@Kusumoto Kusumoto self-requested a review February 15, 2023 15:07
Kusumoto
Kusumoto requested changes Feb 15, 2023
View reviewed changes
Copy link
Owner

@Kusumoto Kusumoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more unit test

@var1ap
Copy link

var1ap commented Jun 22, 2023 •
edited
Loading

Need more unit test

@Kusumoto what kind of unit tests?
People trying to help your lib live, and you can't even tell us what exactly do you need

  1. How many tests
  2. what's your accepting criteria

@Feramor please add some tests in this PR (use ChatGPT to handle boilerplate code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kusumoto Kusumoto Kusumoto requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Feramor @var1ap @Kusumoto