Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_full_field function doesn't take polarization into account #231

Open
JessicaTiebel opened this issue Feb 19, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@JessicaTiebel
Copy link

Hi, I would like to use the get_full_field function to get the full field including the oscillations. While checking how Lasy deals with different polarizations I noticed it doesn't take it into account at all. This leads to wrong output, e.g. having oscillations in y-direction for an in x direction linear polarized laser.

@ax3l
Copy link
Member

ax3l commented Mar 13, 2024

Hi @JessicaTiebel,

Thanks a lot for the report!

Can you please add a minimal script/reproducer of what what does not work for you and how you would like to see it changed? That will make this quicker for someone to pick up (or you can submit a PR if you like, too).

@ax3l ax3l added the bug Something isn't working label Mar 13, 2024
@hightower8083
Copy link
Member

hightower8083 commented Mar 14, 2024

Hi @ax3l and @JessicaTiebel

Currently get_full_field method returns the scalar field, which defines the components via polarization vector as explained here. So indeed currently the output of the method corresponds to Ex component with p=(1,0).

It should be straightforward to add pol argument to get_full_field to allow returning both x and y components with account for phase-shifts due to the complex polarization values. Let me know if this is still of an interest and we can make a PR for that.

@JessicaTiebel
Copy link
Author

Hi,
thanks for the response. Currently I am not using Lasy anymore, so for me it is not of interest. I was just playing around with it and considered it a little bit confussing that get_full_field gives the same result for lasers with different polarizations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants