Multiwarc #9
Open
Multiwarc #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is my understanding that this code has been by now either merged or implemented by us. Am I right? |
|
Not yet merged. And now has a conflict, so it can't be merged as is. |
|
Yep. The other changes were ported in differently (e.g., there's an option to bring back self-signed certificates). From what I see, we need this changeset only: The rest has been already integrated. |
vigna
approved these changes
Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request with just the MultiWarc store : adds a new Store with multiple WARC files output instead of just one big.
Configurable by maxRecordsPerWarc and maxSecondsBetweenDumps