Skip to content

Implement in-game recent activity #18

Implement in-game recent activity

Implement in-game recent activity #18

Triggered via pull request November 5, 2024 08:10
@SlendySlendy
synchronize #855
Status Failure
Total duration 4m 41s
Artifacts

qodana_code_quality.yml

on: pull_request_target
Fit to window
Zoom out
Zoom in

Annotations

6 errors, 209 warnings, and 785 notices
Annotator: ProjectLighthouse/Administration/Maintenance/MigrationTasks/SwitchScoreToUserIdMigration.cs#L131
or DELIMITER expected, got 'jetbrainsRiderDummyI...'
qodana
Resource not accessible by integration
Conditional access qualifier expression is not null according to nullable reference types' annotations: ProjectLighthouse.Servers.Website/Pages/Admin/AdminPanelUsersPage.cshtml#L89
Conditional access qualifier expression is never null according to nullable reference types' annotations
Conditional access qualifier expression is not null according to nullable reference types' annotations: ProjectLighthouse.Servers.Website/Pages/Moderation/CasePage.cshtml#L31
Conditional access qualifier expression is never null according to nullable reference types' annotations
Unused selector: ProjectLighthouse/StaticFiles/css/styles.css#L64
Selector photo-subjects is never used
Disposal of a variable already captured by the 'using' statement: ProjectLighthouse/Serialization/LighthouseSerializer.cs#L59
Variable 'stringWriter' is captured by the 'using' statement and will be automatically disposed when the execution gets out of the scope
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L27
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L73
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L115
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L34
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L76
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L28
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Token/ApiKeyEntity.cs#L11
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L36
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L19
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L84
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L26
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L80
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L34
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L29
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Token/ApiKeyEntity.cs#L13
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L30
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L71
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/ReviewEntity.cs#L39
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L109
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L72
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L22
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L85
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L80
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/SlotEntity.cs#L93
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L78
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Profile/UserEntity.cs#L86
Possible performance issues caused by unlimited string length
Possible performance issues caused by unlimited string length: ProjectLighthouse/Types/Entities/Level/ReviewEntity.cs#L27
Possible performance issues caused by unlimited string length
Path error: ProjectLighthouse.Servers.Website/Pages/Layouts/BaseLayout.cshtml#L97
Path '$PROJECT_DIR$/ProjectLighthouse.Servers.Website/logo-mono.png' is not found
Path error: ProjectLighthouse.Servers.Website/Pages/Partials/SlotCardPartial.cshtml#L46
Path '$PROJECT_DIR$/ProjectLighthouse.Servers.Website/assets' is not found
Path error: ProjectLighthouse.Servers.Website/Pages/Partials/SlotCardPartial.cshtml#L46
Path '$PROJECT_DIR$/ProjectLighthouse.Servers.Website/assets/slotCardBackground.png' is not found
Path error: ProjectLighthouse.Servers.Website/Pages/SlotSettingsPage.cshtml#L42
Path '$PROJECT_DIR$/ProjectLighthouse.Servers.Website/assets/slotCardBackground.png' is not found
Path error: ProjectLighthouse.Servers.Website/Pages/Partials/CommentsPartial.cshtml#L48
Path '$PROJECT_DIR$/ProjectLighthouse.Servers.Website/Pages/Partials/postComment' is not found
Path error: ProjectLighthouse.Servers.Website/Pages/SlotSettingsPage.cshtml#L42
Path '$PROJECT_DIR$/ProjectLighthouse.Servers.Website/assets' is not found
Non-accessed field (private accessibility): ProjectLighthouse/Startup/DebugWarmupLifetime.cs#L21
Field 'applicationStartedRegistration' is assigned but its value is never used
Return value must be disposed but the method or function is not annotated with [MustDisposeResource]: ProjectLighthouse/StorableLists/StorableList.cs#L59
Return value must be disposed but method 'GetEnumerator' is not annotated with \[MustDisposeResource\]
Redundant member initializer: ProjectLighthouse/Types/Entities/Moderation/ModerationCaseEntity.cs#L26
Initializing property by default value is redundant
Redundant using directive: ProjectLighthouse.Servers.Website/Startup/WebsiteStartup.cs#L16
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse/Types/Serialization/Activity/Events/GameEvent.cs#L1
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse.Servers.Website/Controllers/Admin/AdminUserController.cs#L3
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse.Servers.GameServer/Startup/GameServerStartup.cs#L16
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse.Servers.API/Startup/ApiStartup.cs#L1
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse/Types/Serialization/User/GameUser.cs#L10
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse.Servers.Website/Controllers/Admin/AdminUserController.cs#L6
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse.Servers.API/Startup/ApiStartup.cs#L5
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse/Types/Serialization/Activity/Events/GameReviewEvent.cs#L1
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse.Servers.Website/Pages/Partials/LeaderboardPartial.cshtml#L6
Using directive is not required by the code and can be safely removed
Redundant using directive: ProjectLighthouse/Types/Serialization/User/GameUser.cs#L1
Using directive is not required by the code and can be safely removed
qodana
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, github/codeql-action/upload-sarif@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
qodana
CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
qodana
Resource not accessible by integration
qodana
Resource not accessible by integration
qodana
Resource not accessible by integration
RoslynAnalyzers Suggest using IHeaderDictionary properties: ProjectLighthouse/Database/DatabaseContext.ApiTokens.cs#L12
The header 'Authorization' can be accessed using the Authorization property
Use preferred body style (convert into method or operator with preferred body style): ProjectLighthouse/Types/Users/Platform.cs#L8
Code body does not conform to code style settings: use expression body
RoslynAnalyzers Mark members as static: ProjectLighthouse/Serialization/CustomXmlSerializer.cs#L65
Member 'RecursivelyPrepare' does not access instance data and can be marked as static
RoslynAnalyzers Prefer the 'IDictionary.TryGetValue(TKey, out TValue)' method: ProjectLighthouse/Middlewares/RateLimitMiddleware.cs#L135
Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup
RoslynAnalyzers Use concrete types when possible for improved performance: ProjectLighthouse/Administration/Maintenance/MigrationTasks/SwitchScoreToUserIdMigration.cs#L216
Change return type of method 'FixScores' from 'System.Collections.Generic.IEnumerable' to 'System.Collections.Generic.List' for improved performance
RoslynAnalyzers Use concrete types when possible for improved performance: ProjectLighthouse/Tickets/TicketBuilder.cs#L72
Change type of variable 'footerBlob' from 'LBPUnion.ProjectLighthouse.Tickets.TicketData' to 'LBPUnion.ProjectLighthouse.Tickets.BlobData' for improved performance
RoslynAnalyzers Use concrete types when possible for improved performance: ProjectLighthouse/Tickets/TicketBuilder.cs#L66
Change type of variable 'userBlob' from 'LBPUnion.ProjectLighthouse.Tickets.TicketData' to 'LBPUnion.ProjectLighthouse.Tickets.BlobData' for improved performance
RoslynAnalyzers Avoid using 'Enumerable.Any()' extension method: ProjectLighthouse.Servers.API/Controllers/UserEndpoints.cs#L72
Prefer comparing 'Count' to 0 rather than using 'Any()', both for clarity and for performance
RoslynAnalyzers Avoid constant arrays as arguments: ProjectLighthouse.Tests.GameApiTests/Unit/Controllers/UserControllerTests.cs#L115
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array
RoslynAnalyzers Avoid constant arrays as arguments: ProjectLighthouse.Tests.GameApiTests/Unit/Controllers/UserControllerTests.cs#L54
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array
RoslynAnalyzers Avoid constant arrays as arguments: ProjectLighthouse.Tests.GameApiTests/Unit/Controllers/UserControllerTests.cs#L86
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array
RoslynAnalyzers Avoid constant arrays as arguments: ProjectLighthouse.Tests.GameApiTests/Unit/Controllers/UserControllerTests.cs#L68
Prefer 'static readonly' fields over constant array arguments if the called method is called repeatedly and is not mutating the passed array
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons: ProjectLighthouse.Servers.API/Startup/SwaggerFilter.cs#L18
Prefer the string comparison method overload of 'string.StartsWith(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons: ProjectLighthouse.Servers.Website/Pages/Login/RegisterForm.cshtml.cs#L72
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons: ProjectLighthouse/Filter/Filters/Slot/TextFilter.cs#L26
Prefer the string comparison method overload of 'string.Contains(string)' that takes a 'StringComparison' enum value to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons: ProjectLighthouse.Servers.Website/Pages/Email/SetEmailForm.cshtml.cs#L48
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons: ProjectLighthouse.Servers.Website/Pages/UserSettingsPage.cshtml.cs#L68
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
RoslynAnalyzers Use the 'StringComparison' method overloads to perform case-insensitive string comparisons: ProjectLighthouse.Servers.Website/Pages/Login/RegisterForm.cshtml.cs#L64
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
RoslynAnalyzers Use char overload: ProjectLighthouse.Servers.GameServer/Controllers/MessageController.cs#L130
Use 'string.IndexOf(char)' instead of 'string.IndexOf(string)' when you have a string with a single char
RoslynAnalyzers Use char overload: ProjectLighthouse.Tests/Integration/LighthouseServerTest.cs#L91
Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char
RoslynAnalyzers Use char overload: ProjectLighthouse/Files/LbpFileParser.cs#L19
Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char
RoslynAnalyzers Use char overload: ProjectLighthouse.Servers.GameServer/Helpers/GameResourceHelper.cs#L35
Use 'string.StartsWith(char)' instead of 'string.StartsWith(string)' when you have a string with a single char
RoslynAnalyzers Instantiate argument exceptions correctly: ProjectLighthouse/Administration/Maintenance/RepeatingTasks/PerformCaseActionsTask.cs#L103
Call the ArgumentOutOfRangeException constructor that contains a message and/or paramName parameter
RoslynAnalyzers Instantiate argument exceptions correctly: ProjectLighthouse/Administration/Maintenance/RepeatingTasks/PerformCaseActionsTask.cs#L169
Call the ArgumentOutOfRangeException constructor that contains a message and/or paramName parameter
RoslynAnalyzers Instantiate argument exceptions correctly: ProjectLighthouse/Tickets/NPTicket.cs#L137
Method CreateFromBytes passes 'npTicket.TitleId' as the paramName argument to a ArgumentNullException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method.
RoslynAnalyzers Instantiate argument exceptions correctly: ProjectLighthouse.Servers.Website/Controllers/Moderator/ModerationRemovalController.cs#L104
Method DeleteComment passes 'Type' as the paramName argument to a ArgumentOutOfRangeException constructor. Replace this argument with one of the method's parameter names. Note that the provided parameter name should have the exact casing as declared on the method.
Dictionary lookup can be simplified with 'GetValueOrDefault': ProjectLighthouse/Types/Users/GameVersion.cs#L208
Dictionary lookup can be simplified with 'GetValueOrDefault'
Convert constructor into member initializers: ProjectLighthouse/Filter/SlotSortBuilder.cs#L12
Convert constructor into member initializers
Convert constructor into member initializers: ProjectLighthouse/Filter/SlotQueryBuilder.cs#L15
Convert constructor into member initializers
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used: ProjectLighthouse/Extensions/RoomExtensions.cs#L16
Part of loop's body can be converted into LINQ-expression but another 'GetEnumerator' method will be used
Part of foreach loop can be converted into LINQ-expression but another 'GetEnumerator' method will be used: ProjectLighthouse/Helpers/RoomHelper.cs#L215
Part of loop's body can be converted into LINQ-expression but another 'GetEnumerator' method will be used
Member can be made private (non-private accessibility): ProjectLighthouse/Tickets/NPTicket.cs#L40
Accessor 'BodyHeader.set' can be made private
Member can be made private (non-private accessibility): ProjectLighthouse/Types/Users/GameVersion.cs#L150
Field 'LittleBigPlanetVitaTitleIds' can be made private
Member can be made private (non-private accessibility): ProjectLighthouse/Types/Users/GameVersion.cs#L175
Field 'LittleBigPlanetPSPTitleIds' can be made private
Member can be made private (non-private accessibility): ProjectLighthouse/Types/Users/GameVersion.cs#L32
Field 'LittleBigPlanet1TitleIds' can be made private
Member can be made private (non-private accessibility): ProjectLighthouse/Types/Users/GameVersion.cs#L113
Field 'LittleBigPlanet3TitleIds' can be made private
Member can be made private (non-private accessibility): ProjectLighthouse/Helpers/MatchHelper.cs#L14
Field 'UserRecentlyDivedIn' can be made private
Non-accessed field (non-private accessibility): ProjectLighthouse.Servers.Website/Pages/SlotPage.cshtml.cs#L19
Field 'Reviews' is assigned but its value is never used
Non-accessed field (non-private accessibility): ProjectLighthouse.Servers.Website/Pages/SlotPage.cshtml.cs#L21
Field 'Scores' is assigned but its value is never used
Redundant type declaration body: ProjectLighthouse/Types/Filter/ISlotFilter.cs#L6
Redundant empty interface declaration body
Redundant type declaration body: ProjectLighthouse/Types/Filter/Sorts/ISlotSort.cs#L6
Redundant empty interface declaration body
Redundant type declaration body: ProjectLighthouse/Types/Filter/IActivityFilter.cs#L6
Redundant empty interface declaration body
Type is never used (non-private accessibility): ProjectLighthouse/Filter/ActivityQueryBuilder.cs#L11
Class 'ActivityQueryBuilder' is never used (except inside its declaration)