Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just return term list in wikidata search response #83

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

chrisrlc
Copy link
Collaborator

@chrisrlc chrisrlc commented Nov 28, 2023

Fixes output of #parse_authority_response so that it returns what seems to be the format needed by TermsController for displaying the actual response (compared it to response from the loc endpoint).

Example of working wikidata search endpoint:
https://lookup-int.ld4l.org/authorities/search/wikidata/item?q=time

Example of broken wikidata search endpoint:
https://lookup.ld4l.org/authorities/search/wikidata/item?q=time

@chrisrlc chrisrlc marked this pull request as ready for review November 28, 2023 22:10
Copy link
Collaborator

@sfolsom sfolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Wikidata response looks good so I'm going to approve and merge this.

@sfolsom sfolsom merged commit 1ad6aa0 into dev Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants