Skip to content

Commit

Permalink
Address review
Browse files Browse the repository at this point in the history
  • Loading branch information
survived committed Jul 11, 2023
1 parent 17158f7 commit 04e2cca
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cggmp21/src/key_share.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ pub type IncompleteKeyShare<E> = Valid<DirtyIncompleteKeyShare<E>>;
/// Auxiliary information
pub type AuxInfo<L = crate::default_choice::SecurityLevel> = Valid<DirtyAuxInfo<L>>;

/// Dirty (invalidated) incomplete key share
/// Dirty (unvalidated) incomplete key share
///
#[doc = include_str!("../docs/incomplete_key_share.md")]
#[serde_as]
Expand Down Expand Up @@ -75,7 +75,7 @@ pub struct DirtyAuxInfo<L: SecurityLevel = crate::default_choice::SecurityLevel>
pub security_level: std::marker::PhantomData<L>,
}

/// Dirty (invalidated) key share
/// Dirty (unvalidated) key share
///
#[doc = include_str!("../docs/key_share.md")]
#[derive(Clone, Serialize, Deserialize)]
Expand Down Expand Up @@ -487,7 +487,7 @@ impl From<&PartyAux> for π_enc::Aux {
/// it was validated. Library only works with validated data.
///
/// `Valid<T>` provides only immutable access to `T`. For instance, if you want to change content of `T`, you
/// need to [unwrap](Valid::into_inner) it, do necessary modifications, and then validate it again using `TryFrom`.
/// need to [deconstruct](Valid::into_inner) it, do necessary modifications, and then validate it again using `TryFrom`.
#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(into = "T", try_from = "T")]
#[serde(bound(
Expand Down
3 changes: 2 additions & 1 deletion cggmp21/src/security_level.rs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ pub mod _internal {
/// ```
///
/// **Note:** currently, security parameter $m$ is hardcoded into the library. Changing $m$ in security level
/// doesn't change $m$ library uses.
/// doesn't change $m$ library uses due to compiler limitations. We're going to fix that once `feature(generic_const_exprs)`
/// is stable.
#[macro_export]
macro_rules! define_security_level {
($struct_name:ident {
Expand Down

0 comments on commit 04e2cca

Please sign in to comment.