Fix dead links #113

survived · 2024-09-20T10:25:26Z

Closes #112

Signed-off-by: Denis Varlakov <[email protected]>

github-actions · 2024-09-20T10:25:49Z

Crate direct deps

Direct deps

cggmp21-keygen v0.3.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
digest v0.10.6
futures v0.3.24
generic-ec v0.4.1
generic-ec-zkp v0.4.1
hex v0.4.3
key-share v0.4.3 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
paillier-zk v0.4.1
rand_core v0.6.4
rand_hash v0.1.0
round-based v0.3.0
serde v1.0.193
serde_with v2.3.3
sha2 v0.10.6
thiserror v1.0.48
udigest v0.2.1

Compared to base branch

Diff

--- direct-deps-base	2024-09-20 10:46:19.566826720 +0000
+++ direct-deps-pr	2024-09-20 10:46:19.865827794 +0000
@@ -1 +1 @@
-cggmp21-keygen v0.3.1 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.3.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -7 +7 @@
-key-share v0.4.2 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
+key-share v0.4.3 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)

All deps

cargo tree

cggmp21 v0.4.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21)
├── cggmp21-keygen v0.3.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
│   ├── digest v0.10.6
│   │   ├── block-buffer v0.10.3
│   │   │   └── generic-array v0.14.6
│   │   │       ├── serde v1.0.193
│   │   │       │   └── serde_derive v1.0.193 (proc-macro)
│   │   │       │       ├── proc-macro2 v1.0.66
│   │   │       │       │   └── unicode-ident v1.0.4
│   │   │       │       ├── quote v1.0.33
│   │   │       │       │   └── proc-macro2 v1.0.66 (*)
│   │   │       │       └── syn v2.0.32
│   │   │       │           ├── proc-macro2 v1.0.66 (*)
│   │   │       │           ├── quote v1.0.33 (*)
│   │   │       │           └── unicode-ident v1.0.4
│   │   │       └── typenum v1.15.0
│   │   └── crypto-common v0.1.6
│   │       ├── generic-array v0.14.6 (*)
│   │       └── typenum v1.15.0
│   ├── displaydoc v0.2.4 (proc-macro)
│   │   ├── proc-macro2 v1.0.66 (*)
│   │   ├── quote v1.0.33 (*)
│   │   └── syn v2.0.32 (*)
│   ├── generic-ec v0.4.1
│   │   ├── digest v0.10.6 (*)
│   │   ├── generic-ec-core v0.2.0
│   │   │   ├── generic-array v0.14.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   ├── serde v1.0.193 (*)
│   │   │   ├── subtle v2.4.1
│   │   │   └── zeroize v1.6.0
│   │   │       └── zeroize_derive v1.3.2 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.66 (*)
│   │   │           ├── quote v1.0.33 (*)
│   │   │           ├── syn v1.0.101
│   │   │           │   ├── proc-macro2 v1.0.66 (*)
│   │   │           │   ├── quote v1.0.33 (*)
│   │   │           │   └── unicode-ident v1.0.4
│   │   │           └── synstructure v0.12.6
│   │   │               ├── proc-macro2 v1.0.66 (*)
│   │   │               ├── quote v1.0.33 (*)
│   │   │               ├── syn v1.0.101 (*)
│   │   │               └── unicode-xid v0.2.4
│   │   ├── hex v0.4.3
│   │   │   └── serde v1.0.193 (*)
│   │   ├── phantom-type v0.4.2
│   │   │   └── educe v0.4.19 (proc-macro)
│   │   │       ├── enum-ordinalize v3.1.11 (proc-macro)
│   │   │       │   ├── num-bigint v0.4.3
│   │   │       │   │   ├── num-integer v0.1.45
│   │   │       │   │   │   └── num-traits v0.2.15
│   │   │       │   │   └── num-traits v0.2.15
│   │   │       │   ├── num-traits v0.2.15
│   │   │       │   ├── proc-macro2 v1.0.66 (*)
│   │   │       │   ├── quote v1.0.33 (*)
│   │   │       │   └── syn v1.0.101 (*)
│   │   │       ├── proc-macro2 v1.0.66 (*)
│   │   │       ├── quote v1.0.33 (*)
│   │   │       └── syn v1.0.101 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rand_hash v0.1.0
│   │   │   ├── digest v0.10.6 (*)
│   │   │   ├── rand_core v0.6.4
│   │   │   └── udigest v0.2.1
│   │   │       ├── digest v0.10.6 (*)
│   │   │       └── udigest-derive v0.3.0 (proc-macro)
│   │   │           ├── proc-macro2 v1.0.66 (*)
│   │   │           ├── quote v1.0.33 (*)
│   │   │           └── syn v2.0.32 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3
│   │   │   ├── serde v1.0.193 (*)
│   │   │   └── serde_with_macros v2.3.3 (proc-macro)
│   │   │       ├── darling v0.20.1
│   │   │       │   ├── darling_core v0.20.1
│   │   │       │   │   ├── fnv v1.0.7
│   │   │       │   │   ├── ident_case v1.0.1
│   │   │       │   │   ├── proc-macro2 v1.0.66 (*)
│   │   │       │   │   ├── quote v1.0.33 (*)
│   │   │       │   │   ├── strsim v0.10.0
│   │   │       │   │   └── syn v2.0.32 (*)
│   │   │       │   └── darling_macro v0.20.1 (proc-macro)
│   │   │       │       ├── darling_core v0.20.1 (*)
│   │   │       │       ├── quote v1.0.33 (*)
│   │   │       │       └── syn v2.0.32 (*)
│   │   │       ├── proc-macro2 v1.0.66 (*)
│   │   │       ├── quote v1.0.33 (*)
│   │   │       └── syn v2.0.32 (*)
│   │   ├── subtle v2.4.1
│   │   ├── udigest v0.2.1 (*)
│   │   └── zeroize v1.6.0 (*)
│   ├── generic-ec-zkp v0.4.1
│   │   ├── generic-array v0.14.6 (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── serde v1.0.193 (*)
│   │   ├── subtle v2.4.1
│   │   └── udigest v0.2.1 (*)
│   ├── hex v0.4.3 (*)
│   ├── key-share v0.4.3 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)
│   │   ├── displaydoc v0.2.4 (proc-macro) (*)
│   │   ├── generic-ec v0.4.1 (*)
│   │   ├── generic-ec-zkp v0.4.1 (*)
│   │   ├── hex v0.4.3 (*)
│   │   ├── serde v1.0.193 (*)
│   │   ├── serde_with v2.3.3 (*)
│   │   └── thiserror v1.0.48
│   │       └── thiserror-impl v1.0.48 (proc-macro)
│   │           ├── proc-macro2 v1.0.66 (*)
│   │           ├── quote v1.0.33 (*)
│   │           └── syn v2.0.32 (*)
│   ├── rand_core v0.6.4
│   ├── round-based v0.3.0
│   │   ├── displaydoc v0.2.4 (proc-macro) (*)
│   │   ├── futures-util v0.3.24
│   │   │   ├── futures-channel v0.3.24
│   │   │   │   ├── futures-core v0.3.24
│   │   │   │   └── futures-sink v0.3.24
│   │   │   ├── futures-core v0.3.24
│   │   │   ├── futures-io v0.3.24
│   │   │   ├── futures-macro v0.3.24 (proc-macro)
│   │   │   │   ├── proc-macro2 v1.0.66 (*)
│   │   │   │   ├── quote v1.0.33 (*)
│   │   │   │   └── syn v1.0.101 (*)
│   │   │   ├── futures-sink v0.3.24
│   │   │   ├── futures-task v0.3.24
│   │   │   ├── memchr v2.5.0
│   │   │   ├── pin-project-lite v0.2.9
│   │   │   ├── pin-utils v0.1.0
│   │   │   └── slab v0.4.7
│   │   ├── phantom-type v0.3.1
│   │   │   └── educe v0.4.19 (proc-macro) (*)
│   │   ├── round-based-derive v0.2.1 (proc-macro)
│   │   │   ├── proc-macro2 v1.0.66 (*)
│   │   │   ├── quote v1.0.33 (*)
│   │   │   └── syn v1.0.101 (*)
│   │   ├── thiserror v1.0.48 (*)
│   │   └── tracing v0.1.36
│   │       ├── cfg-if v1.0.0
│   │       ├── pin-project-lite v0.2.9
│   │       └── tracing-core v0.1.29
│   ├── serde v1.0.193 (*)
│   ├── serde_with v2.3.3 (*)
│   ├── sha2 v0.10.6
│   │   ├── cfg-if v1.0.0
│   │   ├── cpufeatures v0.2.12
│   │   └── digest v0.10.6 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── digest v0.10.6 (*)
├── futures v0.3.24
│   ├── futures-channel v0.3.24 (*)
│   ├── futures-core v0.3.24
│   ├── futures-executor v0.3.24
│   │   ├── futures-core v0.3.24
│   │   ├── futures-task v0.3.24
│   │   └── futures-util v0.3.24 (*)
│   ├── futures-io v0.3.24
│   ├── futures-sink v0.3.24
│   ├── futures-task v0.3.24
│   └── futures-util v0.3.24 (*)
├── generic-ec v0.4.1 (*)
├── generic-ec-zkp v0.4.1 (*)
├── hex v0.4.3 (*)
├── key-share v0.4.3 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share) (*)
├── paillier-zk v0.4.1
│   ├── digest v0.10.6 (*)
│   ├── fast-paillier v0.1.0
│   │   ├── bytemuck v1.13.1
│   │   │   └── bytemuck_derive v1.4.1 (proc-macro)
│   │   │       ├── proc-macro2 v1.0.66 (*)
│   │   │       ├── quote v1.0.33 (*)
│   │   │       └── syn v2.0.32 (*)
│   │   ├── rand_core v0.6.4
│   │   ├── rug v1.21.0
│   │   │   ├── az v1.2.1
│   │   │   ├── gmp-mpfr-sys v1.6.1
│   │   │   │   └── libc v0.2.153
│   │   │   ├── libc v0.2.153
│   │   │   └── serde v1.0.193 (*)
│   │   ├── serde v1.0.193 (*)
│   │   └── thiserror v1.0.48 (*)
│   ├── generic-ec v0.4.1 (*)
│   ├── rand_core v0.6.4
│   ├── rand_hash v0.1.0 (*)
│   ├── rug v1.21.0 (*)
│   ├── serde v1.0.193 (*)
│   ├── serde_with v3.0.0
│   │   ├── serde v1.0.193 (*)
│   │   └── serde_with_macros v3.0.0 (proc-macro)
│   │       ├── darling v0.20.1 (*)
│   │       ├── proc-macro2 v1.0.66 (*)
│   │       ├── quote v1.0.33 (*)
│   │       └── syn v2.0.32 (*)
│   ├── thiserror v1.0.48 (*)
│   └── udigest v0.2.1 (*)
├── rand_core v0.6.4
├── rand_hash v0.1.0 (*)
├── round-based v0.3.0 (*)
├── serde v1.0.193 (*)
├── serde_with v2.3.3 (*)
├── sha2 v0.10.6 (*)
├── thiserror v1.0.48 (*)
└── udigest v0.2.1 (*)

Compared to base branch

Diff

--- all-deps-base	2024-09-20 10:46:19.710827237 +0000
+++ all-deps-pr	2024-09-20 10:46:20.026828372 +0000
@@ -6 +6 @@
-cggmp21-keygen v0.3.1 (/home/runner/work/cggmp21/cggmp21/base_branch/cggmp21-keygen)
+cggmp21-keygen v0.3.2 (/home/runner/work/cggmp21/cggmp21/pr_branch/cggmp21-keygen)
@@ -34 +34 @@
-key-share v0.4.2 (/home/runner/work/cggmp21/cggmp21/base_branch/key-share)
+key-share v0.4.3 (/home/runner/work/cggmp21/cggmp21/pr_branch/key-share)

github-actions · 2024-09-20T10:27:04Z

The spec was successfully compiled. PDF is available here.

github-actions · 2024-09-20T10:29:16Z

Benchmark Result

Benchmarks

RUST_TESTS_SEED=4f5f2cdee0e8feab64c2b6ce6f9cddc637b7b367d4034398d6b384f1965b128c
n = 3

Non-threshold DKG
Protocol Performance:
  - Protocol took 429.33µs to complete
In particular:
  - Stage: 8.98µs
    - Setup networking: 8.77µs (97.7%)
    - Unstaged: 210.00ns (2.3%)
  - Round 1: 142.12µs
    - Sample x_i, rid_i, chain_code: 64.25µs (45.2%)
    - Sample schnorr commitment: 58.23µs (41.0%)
    - Commit to public data: 19.32µs (13.6%)
    - Unstaged: 320.00ns (0.2%)
  - Round 2: 1.31µs
    - Hash received msgs (reliability check): 1.12µs (85.5%)
    - Unstaged: 190.00ns (14.5%)
  - Round 3: 2.48µs
    - Assert other parties hashed messages (reliability check): 2.36µs (95.2%)
    - Unstaged: 120.00ns (4.8%)
  - Round 4: 38.83µs
    - Validate decommitments: 32.30µs (83.2%)
    - Calculate chain_code: 3.98µs (10.2%)
    - Calculate challege rid: 2.15µs (5.5%)
    - Prove knowledge of `x_i`: 230.00ns (0.6%)
    - Unstaged: 171.00ns (0.4%)
  - Round 5: 235.61µs
    - Validate schnorr proofs: 235.27µs (99.9%)
    - Unstaged: 341.00ns (0.1%)


Threshold DKG
Protocol Performance:
  - Protocol took 1.31ms to complete
In particular:
  - Stage: 1.85µs
    - Setup networking: 1.79µs (96.8%)
    - Unstaged: 60.00ns (3.2%)
  - Round 1: 198.52µs
    - Sample rid_i, schnorr commitment, polynomial, chain_code: 176.10µs (88.7%)
    - Commit to public data: 22.18µs (11.2%)
    - Unstaged: 241.00ns (0.1%)
  - Round 2: 1.27µs
    - Hash received msgs (reliability check): 1.12µs (88.2%)
    - Unstaged: 150.00ns (11.8%)
  - Round 3: 331.00ns
    - Assert other parties hashed messages (reliability check): 210.00ns (63.4%)
    - Unstaged: 121.00ns (36.6%)
  - Round 4: 804.55µs
    - Validate decommitments: 42.63µs (5.3%)
    - Validate data size: 321.00ns (0.0%)
    - Validate Feldmann VSS: 373.53µs (46.4%)
    - Compute rid: 360.00ns (0.0%)
    - Compute chain_code: 1.00µs (0.1%)
    - Compute Ys: 354.62µs (44.1%)
    - Compute sigma: 361.00ns (0.0%)
    - Calculate challenge: 28.83µs (3.6%)
    - Prove knowledge of `sigma_i`: 2.76µs (0.3%)
    - Unstaged: 140.00ns (0.0%)
  - Round 5: 299.00µs
    - Validate schnorr proofs: 297.71µs (99.6%)
    - Derive resulting public key and other data: 1.06µs (0.4%)
    - Unstaged: 230.00ns (0.1%)


Auxiliary data generation protocol
Protocol Performance:
  - Protocol took 9.57s to complete
In particular:
  - Stage: 11.97µs
    - Retrieve auxiliary data: 171.00ns (1.4%)
    - Setup networking: 11.70µs (97.7%)
    - Unstaged: 100.00ns (0.8%)
  - Round 1: 1.16s
    - Retrieve primes (p and q): 80.00ns (0.0%)
    - Compute paillier decryption key (N): 3.01µs (0.0%)
    - Generate auxiliary params r, λ, t, s: 9.05ms (0.8%)
    - Prove Πprm (ψˆ_i): 1.15s (99.2%)
    - Sample random bytes: 2.23µs (0.0%)
    - Compute hash commitment and sample decommitment: 309.27µs (0.0%)
    - Unstaged: 220.00ns (0.0%)
  - Round 2: 1.55µs
    - Hash received msgs (reliability check): 1.27µs (81.9%)
    - Unstaged: 281.00ns (18.1%)
  - Round 3: 570.00ns
    - Assert other parties hashed messages (reliability check): 370.00ns (64.9%)
    - Unstaged: 200.00ns (35.1%)
  - Round 4: 5.91s
    - Validate round 1 decommitments: 599.89µs (0.0%)
    - Validate П_prm (ψ_i): 2.29s (38.7%)
    - Add together shared random bytes: 1.03µs (0.0%)
    - Compute П_mod (ψ_i): 3.45s (58.4%)
    - Assemble security params for П_fac (ф_i): 6.33µs (0.0%)
    - Compute П_fac (ф_i^j): 172.06ms (2.9%)
    - Unstaged: 1.01µs (0.0%)
  - Round 5: 2.49s
    - Validate ψ_j (П_mod): 2.32s (93.1%)
    - Validate ф_j (П_fac): 172.97ms (6.9%)
    - Assemble auxiliary info: 146.29µs (0.0%)
    - Unstaged: 701.00ns (0.0%)


Signing protocol
Protocol Performance:
  - Protocol took 4.18s to complete
In particular:
  - Stage: 153.43µs
    - Map t-out-of-n protocol to t-out-of-t: 65.64µs (42.8%)
    - Retrieve auxiliary data: 83.67µs (54.5%)
    - Precompute execution id and security params: 581.00ns (0.4%)
    - Setup networking: 3.42µs (2.2%)
    - Unstaged: 120.00ns (0.1%)
  - Round 1: 189.64ms
    - Generate local ephemeral secrets (k_i, y_i, p_i, v_i): 49.36µs (0.0%)
    - Encrypt G_i and K_i: 108.08ms (57.0%)
    - Prove ψ0_j: 81.51ms (43.0%)
    - Unstaged: 602.00ns (0.0%)
  - Round 2: 15.63µs
    - Hash received msgs (reliability check): 15.36µs (98.3%)
    - Unstaged: 270.00ns (1.7%)
  - Round 3: 2.24s
    - Assert other parties hashed messages (reliability check): 771.00ns (0.0%)
    - Verify psi0 proofs: 269.97ms (12.1%)
    - Sample random r, hat_r, s, hat_s, beta, hat_beta: 14.78µs (0.0%)
    - Encrypt D_ji: 70.77ms (3.2%)
    - Encrypt F_ji: 35.93ms (1.6%)
    - Encrypt hat_D_ji: 562.86ms (25.2%)
    - Encrypt hat_F_ji: 36.08ms (1.6%)
    - Prove psi_ji: 793.29ms (35.4%)
    - Prove psiˆ_ji: 210.42ms (9.4%)
    - Prove psi_prime_ji : 258.67ms (11.6%)
    - Unstaged: 1.33µs (0.0%)
  - Round 4: 1.57s
    - Retrieve auxiliary data: 4.88µs (0.0%)
    - Validate psi: 165.40ms (10.5%)
    - Validate hat_psi: 166.01ms (10.6%)
    - Validate psi_prime: 938.00ms (59.8%)
    - Compute Gamma, Delta_i, delta_i, chi_i: 216.77ms (13.8%)
    - Prove psi_prime_prime: 81.62ms (5.2%)
    - Unstaged: 490.00ns (0.0%)
  - Presig output: 185.95ms
    - Validate psi_prime_prime: 185.81ms (99.9%)
    - Calculate presignature: 132.81µs (0.1%)
    - Unstaged: 883.00ns (0.0%)
  - Partial signing: 7.02µs
  - Signature reconstruction: 206.02µs

Signed-off-by: Denis Varlakov <[email protected]>

Fix dead links

53c78b8

Signed-off-by: Denis Varlakov <[email protected]>

Bump versions, update changelogs

eaebfd1

Signed-off-by: Denis Varlakov <[email protected]>

survived marked this pull request as ready for review September 20, 2024 10:36

survived requested a review from maurges September 20, 2024 10:36

maurges previously approved these changes Sep 20, 2024

View reviewed changes

Fix a broken intra link in readme

ecbdeee

Signed-off-by: Denis Varlakov <[email protected]>

survived dismissed maurges’s stale review via ecbdeee September 20, 2024 10:45

maurges approved these changes Sep 20, 2024

View reviewed changes

survived merged commit 84bd155 into m Sep 20, 2024
19 checks passed

survived deleted the dead-links branch September 20, 2024 15:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix dead links #113

Fix dead links #113

survived commented Sep 20, 2024

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

Fix dead links #113

Fix dead links #113

Conversation

survived commented Sep 20, 2024

github-actions bot commented Sep 20, 2024 • edited Loading

Crate direct deps

Compared to base branch

All deps

Compared to base branch

github-actions bot commented Sep 20, 2024 • edited Loading

github-actions bot commented Sep 20, 2024 • edited Loading

Benchmark Result

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading

github-actions bot commented Sep 20, 2024 •

edited

Loading