-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serde issue #93
Fix serde issue #93
Conversation
The spec was successfully compiled. PDF is available here. |
Benchmark ResultBenchmarks
|
Crate direct depsDirect deps
Compared to base branchDiff
All depscargo tree
Compared to base branchDiff
|
Only in this PR I've noticed that we serialize scalar in This is how compact things are serialized: this is how VSS setup is serialized: We can compress VSS setup by adding |
We should. I think it's what it should do by default, try both options on deserializing and always serialize as compact. You want to do it in this MR as well? |
Better to do this in a new PR. We gotta release key-share crate, all versions are yanked |
Looks good, let's update generic-ec and go |
@maurges updated the generic-ec |
Turns out that
#[serde(flatten)]
is buggy, and, specifically, it does not preserveis_human_readable
flag, which broke (de)serialization code and compatibility with old key shares.See the issue for more details on the
serde
problem: serde-rs/serde#2704PR adds a workaround that manually reimplements
flatten
functionality.