Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polynomials to zkp #3

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Add polynomials to zkp #3

merged 3 commits into from
Jul 3, 2023

Conversation

survived
Copy link
Contributor

Move polynomials-related logic from cggmp21 to generic-ec-zkp crate

@survived survived force-pushed the polynomial branch 2 times, most recently from 75a6dde to b1f4848 Compare June 26, 2023 11:22
@survived survived marked this pull request as ready for review June 26, 2023 11:30
@survived survived requested a review from jkatzDfns June 27, 2023 14:02
@survived
Copy link
Contributor Author

I have updated cggmp21 code as well to use polynomials from this crate, you can find changes in LFDT-Lockness/cggmp21#49

Copy link
Contributor

@maurges maurges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but generic-ec-zkp and not just generic-ec?

Comment on lines +155 to +158
pub fn value<P, O>(&self, point: &P) -> O
where
O: Zero,
for<'a> O: ops::Mul<&'a P, Output = O> + ops::Add<&'a C, Output = O>,
Copy link
Contributor

@maurges maurges Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at usage in cggmp21: maybe add a variant where C = P = O? Call it value_in for value in ring/field

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk, value_in seems more confusing to me. I didn't find generics annoying when I was updating cggmp21 to use Polynomial. Most of the time compiler can figure out the generics, sometimes I had to specify them, but it was fine

@survived
Copy link
Contributor Author

survived commented Jul 3, 2023

Looks good, but generic-ec-zkp and not just generic-ec?

You're asking why I didn't put it in generic-ec? generic-ec-zkp is better cuz it's basically a crate for all zk-related stuff. generic-ec is a core functionality: points and scalars, and essential utilities like serialization

@survived survived merged commit 32ba817 into m Jul 3, 2023
3 checks passed
@survived survived deleted the polynomial branch July 3, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants