-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polynomials to zkp #3
Conversation
75a6dde
to
b1f4848
Compare
I have updated cggmp21 code as well to use polynomials from this crate, you can find changes in LFDT-Lockness/cggmp21#49 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but generic-ec-zkp and not just generic-ec?
pub fn value<P, O>(&self, point: &P) -> O | ||
where | ||
O: Zero, | ||
for<'a> O: ops::Mul<&'a P, Output = O> + ops::Add<&'a C, Output = O>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at usage in cggmp21: maybe add a variant where C = P = O? Call it value_in
for value in ring/field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk, value_in
seems more confusing to me. I didn't find generics annoying when I was updating cggmp21
to use Polynomial
. Most of the time compiler can figure out the generics, sometimes I had to specify them, but it was fine
You're asking why I didn't put it in |
Move polynomials-related logic from cggmp21 to generic-ec-zkp crate