Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: lib target now builds a shared library. #662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

build: lib target now builds a shared library. #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 134 additions & 35 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# Make hacks
.INTERMEDIATE:

# Library versioning, following libtool's 'version-info' scheme (see:
# info '(libtool) Libtool versioning' or
# https://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html).
LT_CURRENT := 0
LT_REVISION := 0
LT_AGE := 0
LT_VERSION_INFO := $(LT_CURRENT):$(LT_REVISION):$(LT_AGE)
Apteryks marked this conversation as resolved.
Show resolved Hide resolved

# Set target, configuration, version and destination folders

PLATFORM := $(shell uname -s)
Expand Down Expand Up @@ -33,11 +41,47 @@ else
DEFAULT := sdl
endif

ifneq ($(LIBRARY),)
DEFAULT += lib
endif

# Select whether libtool should build/link for static vs shared
# libraries, or both.
ifneq ($(LIBRARY),)
ifeq ($(LIBRARY), shared)
LT_MODE_ARG := -shared
else ifeq ($(LIBRARY), static)
LT_MODE_ARG := -static
else
# Build both static and shared libraries.
LT_MODE_ARG :=
endif
endif

NULL := /dev/null
ifeq ($(PLATFORM),windows32)
NULL := NUL
endif

# Strip a given prefix from a string.
# arg1: The prefix to strip.
# arg2: The text containing the prefix.
# Return $text with $prefix stripped, else nothing.
define strip_prefix =
$(let stripped,$(subst $(1),,$(2)),$\
$(shell test "$(1)$(stripped)" = "$(2)" && echo $(stripped)))
endef

# Simplify a path for use with pkg-config, by replacing $prefix with '${prefix}'
# arg1: prefix, e.g. an installation prefix, such as /usr/local.
# arg2: pkgdir, e.g. a path such as $datadir, $bindir, etc.
# arg3: pkg-config variable name, e.g. 'prefix' or 'exec_prefix'.
# Defaults to 'prefix'.
define simplify_pkgconf_dir =
$(let stripped,$(call strip_prefix,$(1),$(2)),$\
$(if stripped,$${$(or $(3),prefix)}$(stripped),$(2)))
endef

ifneq ($(shell which xdg-open 2> $(NULL))$(FREEDESKTOP),)
# Running on an FreeDesktop environment, configure for (optional) installation
DESTDIR ?=
Expand All @@ -46,6 +90,22 @@ DATA_DIR ?= $(PREFIX)/share/sameboy/
FREEDESKTOP ?= true
endif

# Autoconf-style conventionally named variables.
prefix ?= $(PREFIX)
exec_prefix ?= $(prefix)
includedir ?= $(prefix)/include
bindir ?= $(exec_prefix)/bin
libdir ?= $(exec_prefix)/lib
datadir ?= $(prefix)/share
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be affected by or affect DATA_DIR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that DATA_DIR is for that SameBoy specific data files like the bios while datadir is for package specific data files like the icons and desktop file. In autotools this is the difference between datadir and datarootdir.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I think the Makefile should have those two variables here as well.
Also, since a specific naming convention was already established with DATA_DIR and co., should these also follow the naming scheme?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Autotools convention is widely understood for packagers, so makes sense to follow. I was a bit confused that DATA_DIR meant something different than datadir for SameBoy at first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the autotools conventions you are using datadir as if it was datarootdir and DATA_DIR is what datadir would be.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I had missed that. Then I guess I should rename the datadir I used to datarootdir and have a new datadir be an alias to DATA_DIR.


# Prettified variants for use in the pkg-config file.
override PKGCONF_EXEC_PREFIX = \
$(call simplify_pkgconf_dir,$(prefix),$(exec_prefix))
override PKGCONF_INCLUDEDIR = \
$(call simplify_pkgconf_dir,$(prefix),$(includedir))
override PKGCONF_LIBDIR = \
$(call simplify_pkgconf_dir,$(exec_prefix),$(libdir),exec_prefix)

default: $(DEFAULT)

ifeq ($(MAKECMDGOALS),)
Expand Down Expand Up @@ -111,6 +171,9 @@ BIN := build/bin
OBJ := build/obj
INC := build/include/sameboy
LIBDIR := build/lib
PKGCONF_DIR := $(LIBDIR)/pkgconfig
LIBTOOL_LIBRARY := $(LIBDIR)/libsameboy.la
Apteryks marked this conversation as resolved.
Show resolved Hide resolved
PKGCONF_FILE := $(PKGCONF_DIR)/sameboy.pc

BOOTROMS_DIR ?= $(BIN)/BootROMs

Expand All @@ -135,6 +198,26 @@ PKG_CONFIG := pkg-config
endif
endif

# Libtool makes it easy to correctly build shared libraries with
# version info on both MacOS and GNU/Linux; require it if building
# libraries.
ifneq ($(LIBRARY),)
ifneq (, $(shell command -v libtool 2> $(NULL)))
LIBTOOL := libtool
LIBTOOL_CC := $(LIBTOOL) --tag=CC --mode=compile $(CC) -c
LIBTOOL_LD := $(LIBTOOL) --tag=CC --mode=link $(CC) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you really shouldn't be using libtool at all if you aren't use autotools, this is not going to be portable for slibtool.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems slibtool (which I had no idea existed until now) is not fully compatible with libtool; am I not sure I understand the compatibility argument. Is it not a fault of slibtool to not being fully compatible with libtool? Where would this be an issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentoo allows using slibtool where it works with most packages.

https://wiki.gentoo.org/wiki/Slibtool

Using libtool outside of autotools is always problematic and an extremely suboptimal way to use libtool. The GNU libtool script is one of the worst things ever written (Which is why slibtool exists).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using libtool outside of autotools is always problematic and an extremely suboptimal way to use libtool.

Could you expound on why you say it's "always problematic" to use libtool outside of Autotools? I'm curious of the reasons. I've found some peculiarities a bit challenging while authoring this diff, but I don't foresee problems with it. If Gentoo prefers slibtool, it seems that should work should work using LIBTOOL=slibtool as well, assuming the basic features of libtool I've made used are covered by this alternative implementation of it.

Regarding the quality of libtool itself, I don't particularly mind how pretty or ugly the innards of its implementation are; it's a battle-tested solution that simplified the problem at hand.

I don't mind revising this series more, but I'll need specific problems to address (I don't count "libtool is ugly" as one). Thank you for your continued input!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GNU libtool is supposed to work by generating a ./libtool in the build tree during the ./configure process using LT_INIT from autoconf. The default slibtool symlink to use is rlibtool which depends on this existing so it can determine if it needs shared or static libraries and it will fail if this does not exist or if slibtoolize is not used instead.

Since this is not autotools there is ./configure, LT_INIT or libtoolize/slibtoolize and it will fail with flow errors.

https://wiki.gentoo.org/wiki/Slibtool#flow_error:_unexpected_condition_or_other

To be very blunt, this solution is entirely a non-starter.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we s/libtool/slibtool/ and be done, if it fixes all these libtool shortcomings? Or is more complicated than than to switch to slibtool?

-version-info $(LT_VERSION_INFO) $(LT_MODE_ARG)
else
$(error "please install libtool")
endif
else
# Not building libraries.
LIBTOOL :=
LIBTOOL_CC := $(CC)
LIBTOOL_LD :=
endif


ifeq ($(PLATFORM),windows32)
# To force use of the Unix version instead of the Windows version
MKDIR := $(shell which mkdir)
Expand Down Expand Up @@ -315,11 +398,6 @@ LDFLAGS += -Wl,/NODEFAULTLIB:libcmt.lib
endif
endif

LIBFLAGS := -nostdlib -Wl,-r
ifneq ($(PLATFORM),Darwin)
LIBFLAGS += -no-pie
endif

ifeq ($(CONF),debug)
CFLAGS += -g
else ifeq ($(CONF), release)
Expand Down Expand Up @@ -375,11 +453,14 @@ tester: $(TESTER_TARGET) $(BIN)/tester/dmg_boot.bin $(BIN)/tester/cgb_boot.bin $
_ios: $(BIN)/SameBoy-iOS.app $(OBJ)/installer
ios-ipa: $(BIN)/SameBoy-iOS.ipa
ios-deb: $(BIN)/SameBoy-iOS.deb

# Libraries.
ifeq ($(PLATFORM),windows32)
lib: lib-unsupported
else
lib: $(LIBDIR)/libsameboy.o $(LIBDIR)/libsameboy.a
else ifneq ($(LIBRARY),)
lib: $(LIBTOOL_LIBRARY) $(PKGCONF_FILE)
endif

all: sdl tester libretro lib
ifeq ($(PLATFORM),Darwin)
all: cocoa ios-ipa ios-deb
Expand All @@ -404,6 +485,10 @@ CORE_SOURCES += $(shell ls Windows/*.c)
endif

CORE_OBJECTS := $(patsubst %,$(OBJ)/%.o,$(CORE_SOURCES))
# Libtool PIC objects are created along the .o variants, when building
# a shared library.
CORE_LOBJECTS := $(patsubst %,$(OBJ)/%.lo,$(CORE_SOURCES))
$(CORE_LOBJECTS): $(CORE_OBJECTS)
PUBLIC_HEADERS := $(patsubst Core/%,$(INC)/%,$(CORE_HEADERS))
COCOA_OBJECTS := $(patsubst %,$(OBJ)/%.o,$(COCOA_SOURCES))
IOS_OBJECTS := $(patsubst %,$(OBJ)/%.o,$(IOS_SOURCES))
Expand Down Expand Up @@ -448,22 +533,22 @@ $(OBJ)/%.dep: %

$(OBJ)/Core/%.c.o: Core/%.c
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(FAT_FLAGS) -DGB_INTERNAL -c $< -o $@
$(LIBTOOL_CC) $(CFLAGS) $(FAT_FLAGS) -DGB_INTERNAL -c $< -o $@

$(OBJ)/SDL/%.c.o: SDL/%.c
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) $(SDL_CFLAGS) $(GL_CFLAGS) -c $< -o $@
$(LIBTOOL_CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) $(SDL_CFLAGS) $(GL_CFLAGS) -c $< -o $@

$(OBJ)/XdgThumbnailer/%.c.o: XdgThumbnailer/%.c
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(GIO_CFLAGS) $(GDK_PIXBUF_CFLAGS) -DG_LOG_DOMAIN='"sameboy-thumbnailer"' -c $< -o $@
$(LIBTOOL_CC) $(CFLAGS) $(GIO_CFLAGS) $(GDK_PIXBUF_CFLAGS) -DG_LOG_DOMAIN='"sameboy-thumbnailer"' -c $< -o $@
# Make sure not to attempt compiling this before generating the resource code.
$(OBJ)/XdgThumbnailer/emulate.c.o: $(OBJ)/XdgThumbnailer/resources.h
# Silence warnings for this. It is code generated not by us, so we do not want `-Werror` to break
# compilation with some version of the generator and/or compiler.
$(OBJ)/XdgThumbnailer/%.c.o: $(OBJ)/XdgThumbnailer/%.c
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(GIO_CFLAGS) $(GDK_PIXBUF_CFLAGS) -DG_LOG_DOMAIN='"sameboy-thumbnailer"' -w -c $< -o $@
$(LIBTOOL_CC) $(CFLAGS) $(GIO_CFLAGS) $(GDK_PIXBUF_CFLAGS) -DG_LOG_DOMAIN='"sameboy-thumbnailer"' -w -c $< -o $@

$(OBJ)/XdgThumbnailer/resources.c $(OBJ)/XdgThumbnailer/resources.h: %: XdgThumbnailer/resources.gresource.xml $(BIN)/BootROMs/cgb_boot_fast.bin
-@$(MKDIR) -p $(dir $@)
Expand All @@ -472,21 +557,21 @@ $(OBJ)/XdgThumbnailer/resources.c $(OBJ)/XdgThumbnailer/resources.h: %: XdgThumb

$(OBJ)/OpenDialog/%.c.o: OpenDialog/%.c
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(SDL_CFLAGS) $(GL_CFLAGS) -c $< -o $@
$(LIBTOOL_CC) $(CFLAGS) $(SDL_CFLAGS) $(GL_CFLAGS) -c $< -o $@


$(OBJ)/%.c.o: %.c
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) -c $< -o $@
$(LIBTOOL_CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) -c $< -o $@

# HexFiend requires more flags
$(OBJ)/HexFiend/%.m.o: HexFiend/%.m
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) $(OCFLAGS) -c $< -o $@ -fno-objc-arc -include HexFiend/HexFiend_2_Framework_Prefix.pch
$(LIBTOOL_CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) $(OCFLAGS) -c $< -o $@ -fno-objc-arc -include HexFiend/HexFiend_2_Framework_Prefix.pch

$(OBJ)/%.m.o: %.m
-@$(MKDIR) -p $(dir $@)
$(CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) $(OCFLAGS) -c $< -o $@
$(LIBTOOL_CC) $(CFLAGS) $(FRONTEND_CFLAGS) $(FAT_FLAGS) $(OCFLAGS) -c $< -o $@

# iOS Port

Expand Down Expand Up @@ -723,12 +808,23 @@ libretro:
CC=$(CC) CFLAGS="$(WARNINGS)" $(MAKE) -C libretro BOOTROMS_DIR=$(abspath $(BOOTROMS_DIR)) BIN=$(abspath $(BIN))

# Install for Linux, and other FreeDesktop platforms.
install_headers = install -Dm 644 -t $(DESTDIR)$(includedir)/sameboy $(INC)/*
install_pkgconf_file = install -Dm 644 -t $(DESTDIR)$(libdir)/pkgconfig $(PKGCONF_FILE)

ifneq ($(FREEDESKTOP),)
ifneq ($(LIBRARY),)
install: lib pkgconf
endif
install: $(BIN)/XdgThumbnailer/sameboy-thumbnailer sdl $(shell find FreeDesktop) XdgThumbnailer/sameboy.thumbnailer
(cd $(BIN)/SDL && find . \! -name sameboy -type f -exec install -Dm 644 -T {} "$(DESTDIR)$(DATA_DIR)/{}" \; )
install -Dm 755 -s $(BIN)/SDL/sameboy $(DESTDIR)$(PREFIX)/bin/sameboy
install -Dm 755 -s $(BIN)/XdgThumbnailer/sameboy-thumbnailer $(DESTDIR)$(PREFIX)/bin/sameboy-thumbnailer
install -Dm 644 XdgThumbnailer/sameboy.thumbnailer $(DESTDIR)$(PREFIX)/share/thumbnailers/sameboy.thumbnailer
install -Dm 755 -s $(BIN)/SDL/sameboy $(DESTDIR)$(bindir)/sameboy
install -Dm 755 -s $(BIN)/XdgThumbnailer/sameboy-thumbnailer $(DESTDIR)$(bindir)/sameboy-thumbnailer
install -Dm 644 XdgThumbnailer/sameboy.thumbnailer $(DESTDIR)$(datadir)/thumbnailers/sameboy.thumbnailer
ifneq ($(LIBRARY),)
$(install_headers)
$(install_pkgconf_file)
$(LIBTOOL) --mode=install install -D $(LIBTOOL_LIBRARY) $(libdir)/libsameboy.la
endif
ifeq ($(DESTDIR),)
xdg-mime install --novendor FreeDesktop/sameboy.xml
xdg-desktop-menu install --novendor FreeDesktop/sameboy.desktop
Expand All @@ -738,12 +834,12 @@ ifeq ($(DESTDIR),)
xdg-icon-resource install --novendor --theme hicolor --size $$size --context mimetypes FreeDesktop/ColorCartridge/$${size}x$${size}.png x-gameboy-color-rom; \
done
else
install -Dm 644 FreeDesktop/sameboy.xml $(DESTDIR)$(PREFIX)/share/mime/sameboy.xml
install -Dm 644 FreeDesktop/sameboy.desktop $(DESTDIR)$(PREFIX)/share/applications/sameboy.desktop
install -Dm 644 FreeDesktop/sameboy.xml $(DESTDIR)$(datadir)/mime/sameboy.xml
install -Dm 644 FreeDesktop/sameboy.desktop $(DESTDIR)$(datadir)/applications/sameboy.desktop
for size in 16x16 32x32 64x64 128x128 256x256 512x512; do \
install -Dm 644 FreeDesktop/AppIcon/$$size.png $(DESTDIR)$(PREFIX)/share/icons/hicolor/$$size/apps/sameboy.png; \
install -Dm 644 FreeDesktop/Cartridge/$$size.png $(DESTDIR)$(PREFIX)/share/icons/hicolor/$$size/mimetypes/x-gameboy-rom.png; \
install -Dm 644 FreeDesktop/ColorCartridge/$$size.png $(DESTDIR)$(PREFIX)/share/icons/hicolor/$$size/mimetypes/x-gameboy-color-rom.png; \
install -Dm 644 FreeDesktop/AppIcon/$$size.png $(DESTDIR)$(datadir)/icons/hicolor/$$size/apps/sameboy.png; \
install -Dm 644 FreeDesktop/Cartridge/$$size.png $(DESTDIR)$(datadir)/icons/hicolor/$$size/mimetypes/x-gameboy-rom.png; \
install -Dm 644 FreeDesktop/ColorCartridge/$$size.png $(DESTDIR)$(datadir)/icons/hicolor/$$size/mimetypes/x-gameboy-color-rom.png; \
done
endif
endif
Expand Down Expand Up @@ -783,20 +879,23 @@ $(OBJ)/control.tar.gz: iOS/deb-postinst iOS/deb-prerm iOS/deb-control
$(OBJ)/debian-binary:
-@$(MKDIR) -p $(dir $@)
echo 2.0 > $@

$(LIBDIR)/libsameboy.o: $(CORE_OBJECTS)

# Link library objects with libtool.
$(LIBTOOL_LIBRARY): $(CORE_LOBJECTS)
-@$(MKDIR) -p $(dir $@)
@# This is a somewhat simple hack to force Clang and GCC to build a native object file out of one or many LTO objects
echo "static const char __attribute__((used)) x=0;"| $(CC) $(filter-out -flto,$(CFLAGS)) -c -x c - -o $(OBJ)/lto_hack.o
@# And this is a somewhat complicated hack to invoke the correct LTO-enabled LD command in a mostly cross-platform nature
$(CC) $(FAT_FLAGS) $(CFLAGS) $(LIBFLAGS) $^ $(OBJ)/lto_hack.o -o $@
-@rm $(OBJ)/lto_hack.o

$(LIBDIR)/libsameboy.a: $(LIBDIR)/libsameboy.o
$(LIBTOOL_LD) -rpath $(libdir) $^ -o $@
Copy link
Contributor

@Jan200101 Jan200101 Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rpaths are a general cause for problems and are discouraged wherever possible.

Fedora outright bans a lot of rpaths it considers "broken"
https://fedoraproject.org/wiki/Changes/Broken_RPATH_will_fail_rpmbuild#Definition_of_a_broken_RPATH

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw GNU libtool breaks without the -rpath (While Slibtool doesn't have this problem). Another reason to avoid using libtool here...


$(PKGCONF_FILE): sameboy.pc.in
-@$(MKDIR) -p $(dir $@)
-@rm -f $@
ar -crs $@ $^

sed -e 's,@prefix@,$(prefix),' \
-e 's/@version@/$(VERSION)/' \
-e 's,@exec_prefix@,$(PKGCONF_EXEC_PREFIX),' \
-e 's,@includedir@,$(PKGCONF_INCLUDEDIR),' \
-e 's,@libdir@,$(PKGCONF_LIBDIR),' $< > $@

pkgconf: $(PKGCONF_FILE)

$(INC)/%.h: Core/%.h
-@$(MKDIR) -p $(dir $@)
-@# CPPP doesn't like multibyte characters, so we replace the single quote character before processing so it doesn't complain
Expand All @@ -810,4 +909,4 @@ lib-unsupported:
clean:
rm -rf build

.PHONY: libretro tester cocoa ios _ios ios-ipa ios-deb liblib-unsupported bootroms
.PHONY: libretro tester cocoa ios _ios ios-ipa ios-deb lib lib-unsupported bootroms pkgconf
8 changes: 7 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,18 @@ On Windows, SameBoy also requires:
To compile, simply run `make`. The targets are:
* `cocoa` (Default for macOS)
* `sdl` (Default for everything else)
* `lib` (Creates libsameboy.o and libsameboy.a for statically linking SameBoy, as well as a headers directory with corresponding headers; currently not supported on Windows due to linker limitations)
* `lib` (Creates libsameboy.o, libsameboy.a and libsameboy.so for linking SameBoy, as well as a headers directory with corresponding headers; currently not supported on Windows due to linker limitations)
* `ios` (Plain iOS .app bundle), `ios-ipa` (iOS IPA archive for side-loading), `ios-deb` (iOS deb package for jailbroken devices)
* `libretro`
* `bootroms`
* `tester`

For convenience, when installing the static and shared libraries is
desired, you can specify the LIBRARY=1 make variable to have the
libraries built as part of the default target, as well as installed,
along the headers. Alternatively, `LIBRARY=shared` will install just
the shared library, while `LIBRARY=static` only the static one.

You may also specify `CONF=debug` (default), `CONF=release`, `CONF=native_release` or `CONF=fat_release` to control optimization, symbols and multi-architectures. `native_release` is faster than `release`, but is optimized to the host's CPU and therefore is not portable. `fat_release` is exclusive to macOS and builds x86-64 and ARM64 fat binaries; this requires using a recent enough `clang` and macOS SDK using `xcode-select`, or setting them explicitly with `CC=` and `SYSROOT=`, respectively. All other configurations will build to your host architecture, except for the iOS targets. You may set `BOOTROMS_DIR=...` to a directory containing precompiled boot ROM files, otherwise the build system will compile and use SameBoy's own boot ROMs.

The SDL port will look for resource files with a path relative to executable and inside the directory specified by the `DATA_DIR` variable. If you are packaging SameBoy, you may wish to override this by setting the `DATA_DIR` variable during compilation to the target path of the directory containing all files (apart from the executable, that's not necessary) from the `build/bin/SDL` directory in the source tree. Make sure the variable ends with a `/` character. On FreeDesktop environments, `DATA_DIR` will default to `/usr/local/share/sameboy/`. `PREFIX` and `DESTDIR` follow their standard usage and default to an empty string an `/usr/local`, respectively
Expand Down
10 changes: 10 additions & 0 deletions sameboy.pc.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
prefix=@prefix@
exec_prefix=@exec_prefix@
includedir=@includedir@
libdir=@libdir@

Name: sameboy
Description: The SameBoy library
Version: @version@
Cflags: -I${includedir}/sameboy
Libs: -L${libdir} -lsameboy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When linking libsameboy.a -lm appears to be needed

Libs.private: -lm