Added documentation to gp.py, input.py, and param.py #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 28, 2024 13:51
I also removed the multheadedattention activation type (plus the associated apply_attention function) because they did not make sense in this class. I have now documented the MLP class, but need to add documentation to the autoencoder class.
I added comments + doc strings to the Autoencoder class.
gplasdi had an instance of np.Inf (which is depricated). I also fixed a typo in latent_spaces.py
I also reformatted enums.py
punkduckable
force-pushed
the
param_input_gp_documentation
branch
from
cdf2719
to
4bbd63a
Compare
|
If this PR does not overlap with PR #15 , We can simply rebase the last 3 commits against the current main branch and review this PR concurrently with PR #15 , rather than waiting for it to be merged. We have resolved all the delayed, conflicting PRs, so probably this is the last time we need rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added documentation to three files in this commit:
gp.py,input.py, andparam.py. Functionally, there are no changes to the code (the changes are only cosmetic. The code itself is identical).