Neutral viscosity bugfix #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging GitHub Actions workflow into develop
Consolidate version checking from master
Fixed bug in neutral viscosity loop - Do loop ended at radial index ny rather than ny+1 - Changes affect the Jacobian calculation - Does not affect the full RHS evaluation - Bug should not affect the steady-state solution - Bugfix should improve convergence behavior to steady-state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in neutral viscosity loop
Advanced version to 8.0.4-patch0 as a precaution: converged fnorms may change after updating, negligible impact on steady-state solution expected