-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jouleheating bugfix #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
holm10
commented
Sep 22, 2023
- Adds option oldseec
- Defaults to 1, using old seec model
- oldseec = 0 uses new model
- New model includes radial v*grad-P components previously not included
- Option to use old model will be removed in future UEDGE versions
- Raises warning to user if old model is used
- jhswitch > 0 should not be used
- Double-accounts for joule heating, including bug
- Bug causes the heating term to not be multiplied by the finite element (cell volume)
- Thus, using jhswitch > 0 severly over-estimates joule heating
- Using deprecated jhswitch options raises warning in UEDGE
- Options jhswitch > 0 will be removed from future UEDGE versions
- Adds option oldseec - Defaults to 1, using old seec model - oldseec = 0 uses new model - New model includes radial v*grad-P components previously not included - Option to use old model will be removed in future UEDGE versions - Raises warning to user if old model is used - jhswitch > 0 should not be used - Double-accounts for joule heating, including bug - Bug causes the heating term to not be multiplied by the finite element (cell volume) - Thus, using jhswitch > 0 severly over-estimates joule heating - Using deprecated jhswitch options raises warning in UEDGE - Options jhswitch > 0 will be removed from future UEDGE versions
To avoid failing the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.