Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jouleheating bugfix #52

Merged
merged 15 commits into from
Oct 27, 2023
Merged

Jouleheating bugfix #52

merged 15 commits into from
Oct 27, 2023

Conversation

holm10
Copy link
Collaborator

@holm10 holm10 commented Sep 22, 2023

  • Adds option oldseec
    • Defaults to 1, using old seec model
    • oldseec = 0 uses new model
    • New model includes radial v*grad-P components previously not included
    • Option to use old model will be removed in future UEDGE versions
    • Raises warning to user if old model is used
  • jhswitch > 0 should not be used
    • Double-accounts for joule heating, including bug
    • Bug causes the heating term to not be multiplied by the finite element (cell volume)
    • Thus, using jhswitch > 0 severly over-estimates joule heating
    • Using deprecated jhswitch options raises warning in UEDGE
    • Options jhswitch > 0 will be removed from future UEDGE versions

llnl-fesp and others added 14 commits August 15, 2023 13:09
@llnl-fesp
Builds basis version without any <pkg>_basis.v files.
74b01ad
@llnl-fesp
Simplified mppl macros.
ea735f4
@llnl-fesp
Removed unneeded handlers sources.
0c6a787
@llnl-fesp
Changed gchange calls to be compatible with Python version.
853c582
@llnl-fesp
Merge branch 'master' of https://github.com/LLNL/UEDGE
cc15c0d
@llnl-fesp
Update
0fdafe4
@holm10
Merge branch 'develop' into master
47883fd
@holm10
Revert "Merge branch 'develop' into master"
33464d9 
This reverts commit 47883fd, reversing
changes made to 0fdafe4.
@holm10
Merge branch 'master' of https://github.com/LLNL/UEDGE
e564aad
@llnl-fesp
Raises an error if the make fails
17fd105
@holm10
Fix Joule heating bug
596213c 
- Adds option oldseec
  - Defaults to 1, using old seec model
  - oldseec = 0 uses new model
  - New model includes radial v*grad-P components previously not included
  - Option to use old model will be removed in future UEDGE versions
  - Raises warning to user if old model is used
- jhswitch > 0 should not be used
  - Double-accounts for joule heating, including bug
  - Bug causes the heating term to not be multiplied by the finite element (cell volume)
  - Thus, using jhswitch > 0 severly over-estimates joule heating
  - Using deprecated jhswitch options raises warning in UEDGE
  - Options jhswitch > 0  will be removed from future UEDGE versions
@holm10
Add missing terms for y-grad calculation
4b6df21
@holm10
Makes UEDGE naggier when using old models
f7f6042
@holm10
Makes pytests use override=1
c70f8c4 
To avoid failing the tests
@holm10 holm10 changed the base branch from master to develop October 27, 2023 20:19
@holm10 holm10 merged commit 153a803 into develop Oct 27, 2023
2 checks passed
@holm10 holm10 deleted the jouleheating_bugfix branch October 27, 2023 20:45
holm10 added a commit that referenced this pull request Oct 28, 2023
@holm10
Revert "Merge pull request #52 from LLNL/jouleheating_bugfix"
e3e6675 
This reverts commit 153a803, reversing
changes made to 7da5439.
@holm10 holm10 restored the jouleheating_bugfix branch October 28, 2023 00:15
@holm10 holm10 mentioned this pull request Oct 28, 2023
Merged
holm10 added a commit to holm10/UEDGE that referenced this pull request Jan 11, 2024
@holm10
Revert "Merge pull request LLNL#52 from LLNL/jouleheating_bugfix"
7d491a0 
This reverts commit 153a803, reversing
changes made to 7da5439.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holm10 @llnl-fesp