-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse Matrix Tests Refactoring #173
Open
cameronrutherford
wants to merge
8
commits into
develop
Choose a base branch
from
sparse-matrix-tests-dev
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d removed unused getMatrixData
ashermancinelli
approved these changes
Dec 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good!
Co-authored-by: Asher Mancinelli <[email protected]>
@cameronrutherford Thanks! This looks much better and clearer. |
@pelesh : is this PR still under development or it only waits for you review? |
Not quite ready to be merged yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Once #103 is resolved, this implementation-specific section in testMatrixSparse.cpp should probably be removed, along with a RAJA specific test implemented. A new issue can be created to track this if need be, or implementing this test can be part of closing out #103:
I will note that this dynamic cast in the template function will always throw a warning:
warning: dynamic_cast of ‘hiop::tests::MatrixTestsRajaSparseTriplet test’ to ‘class hiop::tests::MatrixTestsSparseTriplet*’ can never succeed
. It seems like an appropriate solution for the moment.