Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on-the-fly FOM orbital snapshot saving #229

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

dreamer2368
Copy link
Collaborator

@dreamer2368 dreamer2368 commented May 1, 2024

This PR must be rebased after PR #228 is merged to ROMFPMD.

MGmol<OrbitalsType>::save_orbital_snapshot saves the orbital wave functions in libROM snapshot matrix format. The snapshot is saved at:

  1. At the end of Quench type simulation (at cleanup())
  2. At the restart file saving during MD type simulation.

In order to turn on this snapshot saving, the input config file should have ROM.offline.save_librom_snapshot to be true.

@dreamer2368 dreamer2368 marked this pull request as ready for review May 2, 2024 21:00
Copy link
Collaborator

@oseikuffuor1 oseikuffuor1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreamer2368 Looks good, but I recommended a small change in the comments. Please take a look and let me know if you have questions.

@dreamer2368
Copy link
Collaborator Author

@dreamer2368 Looks good, but I recommended a small change in the comments. Please take a look and let me know if you have questions.

This is reflected now.

@oseikuffuor1 oseikuffuor1 merged commit 0f7c1cc into ROMFPMD May 2, 2024
2 checks passed
@jeanlucf22 jeanlucf22 deleted the new-rombasis2 branch May 3, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants