Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace bytes of compressed stream with uint8_t #106

Merged
merged 21 commits into from
Oct 1, 2020
Merged

replace bytes of compressed stream with uint8_t #106

Changes from 8 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2361be0
replace bytes of compressed stream to uint8_t
halehawk Sep 17, 2020
3479dd7
Update python/zfpy.pyx
halehawk Sep 17, 2020
b737a9b
Update python/zfpy.pyx
halehawk Sep 17, 2020
14131c3
add const to char*
halehawk Sep 17, 2020
470b0f5
Merge branch 'develop' of https://github.com/halehawk/zfp into develop
halehawk Sep 17, 2020
ebd227e
remove const for test
halehawk Sep 18, 2020
d87759c
add <char*> in stream_open
halehawk Sep 18, 2020
01a5a97
change to void *
halehawk Sep 18, 2020
0a730b8
check cython version in zfpy.pyx
halehawk Sep 19, 2020
c1e444e
add cython version check in travis.sh
halehawk Sep 19, 2020
07022fd
enable cython3 upgrade on xenial
halehawk Sep 19, 2020
0f74a36
change cython3 in .travis.yml
halehawk Sep 19, 2020
b3bc658
use pip3 instead pip
halehawk Sep 19, 2020
219f0ce
remove upgrade pip
halehawk Sep 19, 2020
b4c96fb
change back to pip
halehawk Sep 19, 2020
1a65860
upgrade pip first
halehawk Sep 19, 2020
f084835
change cython3 to cython
halehawk Sep 19, 2020
bd0e413
remove apt-get cython3
halehawk Sep 19, 2020
0583611
remove print cython version
halehawk Sep 20, 2020
fdde60b
change to void, add tests similar to ensure_ndarray
halehawk Sep 26, 2020
f1709a4
changed uint8_t and memoryview test
halehawk Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions python/zfpy.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import cython
from libc.stdlib cimport malloc, free
from cython cimport view
from cpython cimport array
from libc.stdint cimport uint8_t
import array

import itertools
Expand Down Expand Up @@ -245,7 +246,7 @@ cdef _validate_4d_list(in_list, list_name):
)

cpdef np.ndarray _decompress(
bytes compressed_data,
const uint8_t[::1] compressed_data,
zfp_type ztype,
shape,
out=None,
Expand All @@ -260,10 +261,10 @@ cpdef np.ndarray _decompress(
raise ValueError("Cannot decompress in-place")
_validate_4d_list(shape, "shape")

cdef char* comp_data_pointer = compressed_data
cdef const char* comp_data_pointer = <const char*>&compressed_data[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please change this to const void* to avoid any confusion why the pointer is initially cast to a (signed) char*?

cdef zfp_field* field = zfp_field_alloc()
cdef bitstream* bstream = stream_open(
comp_data_pointer,
<void *>comp_data_pointer,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this second cast from const void* to void* necessary, or can comp_data_pointer be declared as void*?

len(compressed_data)
)
cdef zfp_stream* stream = zfp_stream_open(bstream)
Expand Down Expand Up @@ -329,15 +330,15 @@ cpdef np.ndarray _decompress(
return output

cpdef np.ndarray decompress_numpy(
bytes compressed_data,
const uint8_t[::1] compressed_data,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry there may have been an extra space in the suggestion before. Maybe that helps?

Suggested change
const uint8_t[::1] compressed_data,
const uint8_t[::1] compressed_data,

):
if compressed_data is None:
raise TypeError("compressed_data cannot be None")

cdef char* comp_data_pointer = compressed_data
cdef const char* comp_data_pointer = <const char *>&compressed_data[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here; const void* or void*.

cdef zfp_field* field = zfp_field_alloc()
cdef bitstream* bstream = stream_open(
comp_data_pointer,
<void *>comp_data_pointer,
len(compressed_data)
)
cdef zfp_stream* stream = zfp_stream_open(bstream)
Expand Down