Fix CI

[nabobalis]

Summary by Sourcery

Fix CI by updating linting rules and exclusions in ruff.toml, refactoring test files for consistency, and replacing pkg_resources with importlib.resources for resource management.

Enhancements:

• Refactor code to use importlib.resources instead of pkg_resources for resource management.

CI:

• Update CI configuration by modifying the ruff.toml file to adjust linting rules and exclusions.

Tests:

• Refactor test files to use ROOTDIR instead of rootdir for consistency and update test assertions to remove decimal precision.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR focuses on improving code quality and CI configuration through several key changes: updating the Ruff linter configuration, fixing test failures, adding type hints, and modernizing package dependencies. The changes are primarily maintenance-focused rather than introducing new features.

Updated class diagram for SpectrogramCube

classDiagram
    class SpectrogramCube {
        +__init__(data, wcs, mask, copy) : None
        +__getitem__(item)
        +__repr__() : str
        +__str__() : str
        +plot(*args, **kwargs)
    }

Loading

Updated class diagram for SGMeta

classDiagram
    class SGMeta {
        +__init__(header, spectral_window, **kwargs) : None
        +__str__() : str
        +__repr__() : str
        +_construct_time(key)
    }

Loading

Updated class diagram for ObsID

classDiagram
    class ObsID {
        +__init__(obsid) : None
        +__repr__() : str
        +_read_obsid(obsid)
    }

Loading

Updated class diagram for SJI

classDiagram
    class SJI {
        +__init__(data, wcs, mask, copy, scaled, **kwargs) : None
        +__repr__() : str
        +__str__() : str
    }

Loading

File-Level Changes

Change	Details	Files
Updated Ruff linter configuration and rules	Simplified lint selection by using 'ALL' instead of individual rules Added new ignore rules for type annotations and docstring formatting Added per-file ignore configurations for specific file types Updated extend-exclude list for ignored directories	ruff.toml
Fixed test failures and improved test stability	Added pytest.mark.xfail to failing tests Fixed numpy warnings by adding np.errstate context managers Updated test assertions to use shape instead of dimensions Fixed time unit inconsistencies in tests	irispy/tests/test_response.py irispy/tests/test_sji_fd.py irispy/tests/test_spectrograph.py irispy/tests/test_sji.py
Added type hints and improved code organization	Added return type hints to str and repr methods Added -> None type hints to init methods Reordered all lists alphabetically Renamed rootdir to ROOTDIR to follow constants naming convention	irispy/spectrograph.py irispy/sji.py irispy/obsid.py irispy/data/test/__init__.py
Updated package dependencies and configuration	Increased minimum Python version to 3.10 Updated dependency versions including sunpy>=6.0.0 Switched to git dependency for ndcube Updated pre-commit hooks to latest versions	pyproject.toml .pre-commit-config.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @nabobalis - I've reviewed your changes - here's some feedback:

Overall Comments:

• The dependency on ndcube @ git+https://github.com/sunpy/ndcube@YOLO is not suitable for a release. Please use a proper release version or at minimum a specific commit hash rather than an unstable branch name.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟡 Testing: 2 issues found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

issue (bug_risk): Using an unstable git branch reference for a production dependency is risky

Consider using a stable version or at minimum pinning to a specific commit hash for reproducible builds.

[sourcery-ai]

issue (testing): Missing explanation for expected test failure

The test is marked as expected to fail but there's no explanation why. Please add a reason parameter to the xfail decorator to document why this test is expected to fail. This helps other developers understand if this is a known limitation or a temporary issue that needs to be fixed.

[sourcery-ai]

issue (testing): Decimal precision removed from assertions

The decimal precision parameter was removed from these assertions. This could make the tests more brittle as they now require exact matches. Consider keeping the decimal parameter to allow for small floating point differences.