Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link fixing #1302

Merged
merged 9 commits into from
Nov 6, 2024
Merged

link fixing #1302

merged 9 commits into from
Nov 6, 2024

Conversation

Rider21
Copy link
Contributor

@Rider21 Rider21 commented Nov 3, 2024

closes #1298

@nyagami
Copy link
Member

nyagami commented Nov 4, 2024

doest eact-native-url-polyfill work?

@Rider21 Rider21 marked this pull request as ready for review November 4, 2024 12:12
@Rider21
Copy link
Contributor Author

Rider21 commented Nov 4, 2024

It works, forgot to add
I removed the dependencies:

  • urlencode it is no longer used in plugins.
  • I replaced qs with react-native-url-polyfill which also has an implementation of URLSearchParams.

@nyagami
Copy link
Member

nyagami commented Nov 4, 2024

I think urlencode is still helpful for some sites using uncommon encoding

@Rider21
Copy link
Contributor Author

Rider21 commented Nov 4, 2024

I think fetchText with FileReader will suffice.
And the rest can be hardcoded into plugins if needed

@nyagami
Copy link
Member

nyagami commented Nov 4, 2024

No, in case of shu69 (if i remember correctly), we have to encode the search param

@nyagami nyagami merged commit 4bc3638 into LNReader:master Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are no illustrations for downloaded chapters
2 participants