Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reconnect logic #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add reconnect logic #7

wants to merge 1 commit into from

Conversation

smithamax
Copy link
Member

@smithamax smithamax commented Oct 11, 2024 •
edited
Loading

We could make this compatible with the old version, but thinking we make it a major version bump to make sure projects can't update without supporting reconnect

@smithamax smithamax self-assigned this Oct 11, 2024
@smithamax smithamax requested a review from denwilliams October 11, 2024 03:01
denwilliams
denwilliams reviewed Oct 15, 2024
View reviewed changes
Copy link
Contributor

@denwilliams denwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add instructions to readme for createConnection and also looks like you added close, so guessing that now needs to be called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denwilliams denwilliams denwilliams left review comments

Assignees

@smithamax smithamax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smithamax @denwilliams