PowerSpectrum abc with arbitrary precision options.
#1063
Closed
+625
−1,177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 9, 2023
|
This is not to be reviewed until existing capabilities have been moved to v3. There is new science implementations that take priority. |
|
Just doing some general cleaning of the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like with
Baryons,HaloProfile,MassFuncetc. this PR introduces aPowerSpectrumbase class which returns aPk2Dobject containing the power spectrum of a particular model. The functions inboltzmann.pyare now subclasses of the base class, which allows for easy model extension.With this one, I ported the C code for the Eisenstein-Hu and BBKS fitting formulas to Python, into their own subclasses.
It also solves a long-standing issue, of passing arbitrary parameters to the models. For example, users can now exploit that to pass any precision parameter CLASS accepts.
Closes #588 , closes #424 .
May also address #114 if slightly modified.