Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label non-parallel stages as such #252

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Label non-parallel stages as such #252

merged 1 commit into from
Jun 16, 2022

Conversation

joezuntz
Copy link
Collaborator

Addresses issue #250 .

Also renames some classes which did not match their name attribute

Copy link
Contributor

@empEvil empEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. If I understand Ceci correctly it should now mean that if we try to nprocess =2 for this it should warn us or stop it? Also more importantly how do we ensure the lack of parallelization is reflected in documentation, rather than by guess?

@joezuntz
Copy link
Collaborator Author

It should complain if you try and run with nprocess=2, but yes, we should try and make the doc generator reflect it somehow. And maybe write a few notes in docstring about what good choices are.

@empEvil
Copy link
Contributor

empEvil commented Jun 16, 2022

we shpuld leave up the issue, for the documentations side

@joezuntz joezuntz merged commit ba13f68 into master Jun 16, 2022
@joezuntz joezuntz deleted the parallel_label branch June 16, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants