Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #311 create cl make bin stage #314

Merged
merged 25 commits into from
Oct 19, 2023

Conversation

marina-ricci
Copy link
Contributor

@marina-ricci marina-ricci commented Jul 20, 2023

Linked to #311. This issue creates a stage to bin the cluster catalogs in bins of richness and redshift and output a tomography TX file. Pipeline and config files are also written to run the CL pipeline, as well as the batch script for CCin2p3 and a notebook running the pipeline and exploring the input and output files.

@marina-ricci marina-ricci marked this pull request as draft July 20, 2023 18:39
@marina-ricci
Copy link
Contributor Author

marina-ricci commented Oct 17, 2023

For the CLClusterBinningRedshiftRichness stage :

# This is the initial cluster catalog - RAs, Decs, richess, redshift, etc.
cluster_catalog="./data/example/inputs/cluster_catalog.hdf5",

# This is the output for this stage
cluster_tomography="./data/cosmodc2/outputs-1deg2-CL/cluster_catalog_tomography.hdf5",

I explicitly wrote different bin definition in the config file and as the default in the pipeline stage to make it explicit in the notebook which is what.

@combet combet assigned combet and unassigned combet Oct 18, 2023
@marina-ricci marina-ricci marked this pull request as ready for review October 18, 2023 13:48
@marina-ricci
Copy link
Contributor Author

@cavestruz : the PR is ready on my side. Normally you should have all info from the notebook! Please test the nersc launcher (just for the 1deg2 should be sufficient) as I did not test it. We should find better way to work at the two site with changing just the launcher file, but I did not find the proper way to do it. So you also have to change the first lines in the pipeline files.

@cavestruz cavestruz self-assigned this Oct 18, 2023
…e comment/uncommenting happen in the notebook level
…he comment/uncommenting happen in the notebook level
… steps between NERSC/IN2P3. Now, there are separate files for each.
Copy link
Contributor

@cavestruz cavestruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primary changes are to change the 20sqdeg yaml files so this works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this submission in NERSC.

sbatch examples/cosmodc2/1deg2-nersc.sub

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this file to two separate config-1deg2-CL-{in2p3,nersc}.yml and put each option in the notebook, Run_CL_pipeline.ipynb so the comment/uncommenting happens at the notebook level as opposed to inside the yml file.

Copy link
Contributor

@cavestruz cavestruz Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This has some lines that need updating to run, consistent with the 1deg2 version.

Copy link
Contributor

@cavestruz cavestruz Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This has some lines that need updating to run, consistent with the 1deg2 version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor additions here to account for different in2p3 vs. nersc files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made minor change here, so there are separate yaml files depending on where the user is running the notebook.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this out now with the squeue submission. Will then check if latter portion of notebook runs on NERSC with the output of the 20deg2 submission that uses this yaml file.

@marina-ricci
Copy link
Contributor Author

marina-ricci commented Oct 19, 2023

@cavestruz : I did some cleaning as there were typos in the files and reorganized the notebook to clarify the 2 approaches to run : direclty from jupyter or via pipeline/ceci. I commented all unused stages / input so that the pipeline chart for this PR is just:
image
Please check again everything runs, it should be very fast, even on the 20deg2.

Copy link
Contributor

@cavestruz cavestruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - I am able to run everything in the notebook, and submit the sbatch examples/cosmodc2/20deg2-nersc.sub to run the tail end of cells in Run_CL_counts_pipeline.ipynb.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this out now with the squeue submission. Will then check if latter portion of notebook runs on NERSC with the output of the 20deg2 submission that uses this yaml file.

@cavestruz cavestruz merged commit 668ed86 into master Oct 19, 2023
10 checks passed
@cavestruz cavestruz deleted the issue_#311_create_CL_make_bin_stage branch October 19, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants