Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psf xim #363

Merged
merged 20 commits into from
Sep 30, 2024
Merged

Psf xim #363

merged 20 commits into from
Sep 30, 2024

Conversation

jmjefferson
Copy link
Collaborator

No description provided.

@jmjefferson jmjefferson marked this pull request as draft July 22, 2024 14:34
@jmjefferson jmjefferson marked this pull request as ready for review August 20, 2024 14:16
@joezuntz joezuntz self-assigned this Sep 6, 2024
@joezuntz joezuntz self-requested a review September 7, 2024 08:18
Copy link
Collaborator

@joezuntz joezuntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine - I've requested a few changes in the notes here.

txpipe/psf_diagnostics.py Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Outdated Show resolved Hide resolved
txpipe/psf_diagnostics.py Show resolved Hide resolved
@joezuntz joezuntz merged commit 1c510ca into master Sep 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants