LSST DESC Note: The Twinkles 1 Strong Lens Population #450
Conversation
|
The lens galaxy matching shouldn't be a part of the sprinkler since we just run the example notebook once and create a new fits catalog of lens systems with the additional information we have added about the lens galaxies. At that point the sprinkler just uses this new catalog whenever you run it. I think we should certainly mention it in the mock catalog section of the notebook and maybe even summarize the example notebook adding some of the plots from there, but I don't think the code belongs in the sprinkler. |
|
OK: I guess the Note should explain this, and instead present the matching
as providing necessary additional information to what is present in the
OM10 catalog. Thanks!
…On Tue, May 23, 2017 at 9:39 PM, Bryce Kalmbach ***@***.***> wrote:
The lens galaxy matching shouldn't be a part of the sprinkler since we
just run the example notebook once and create a new fits catalog of lens
systems with the additional information we have added about the lens
galaxies. At that point the sprinkler just uses this new catalog whenever
you run it. I think we should certainly mention it in the mock catalog
section of the notebook and maybe even summarize the example notebook
adding some of the plots from there, but I don't think the code belongs in
the sprinkler.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#450 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArY9zSKTYAgHvnXVaPyUaMkUML8-njlks5r87R-gaJpZM4NeLRD>
.
|
|
This note is ready for comments. The Discussion and Conclusions section is kind of a set of bullet point response right now and any comments on the content there would be helpful before I write it out. |
There was a problem hiding this comment.
Thanks @jbkalmbach - looking at the main.ipynb notebook now. Some comments:
-
The JBK/PJM flags in the text cells need removing - except where you want me to make edits or add text.
-
I'm confused about the 2-mag offset in AGN image brightness - this seems hard to make just by getting the SED wrong (using rest frame instead of observed frame). Are you sure there is not some other problem, with the normlization / zero point? Are you comparing unmagnified source plane inputs with observed magnified outputs? 2 mags is a lot. Are all the source plane AGN too bright by this amount?
-
I don't see the matching work you did, with empiriciSN and XDGMM. Wasn't that in a separate notebook? I think it needs to be pasted in here to keep all your sprinkling work together.
-
It's good to see the quasar image positions line up with OM10!
@jbkalmbach Here's an ipython notebook for us to write up the SL inputs work (showing the sprinkler in action, and the lens matching etc, #449). Can you take a look and maybe refine the section headings, do some subsectioning etc?
It looks to me as though we might need to refactor the sprinkler code so that it handles the lens galaxy matching - that stuff is just in an
examplenotebook right now. What do you think?We won't merge this PR until we've finished writing the Note and the group has reviewed it.