Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for likelihood specification and factory API #397

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tilmantroester
Copy link
Contributor

This is a more-or-less working prototype of a yaml-based likelihood specification, following the discussion thread.

Some features I think are nice:

  • Separation of model and data specification: specifying the model does not require knowledge about the data
  • Flexible: by using jsonargparse for dependency injection, the model specification can use systematics directly from firecrown or elsewhere, without the factory having to know about these systematics.
  • I tried to separate the yaml-parsing logic from the likelihood factory logic, so the yaml format is not a hard requirement

Some obvious things that are still missing

  • Clusters and SN. This only supports 2pt at the moment. I'm not very familiar with clusters workflow and an earlier version I had has stopped working.
  • Features such as scale and bin cuts, but that should be straightforward to implement.
  • Robustness, testing, etc.

I hope this PR can function as a starting point of a discussion on where this specification might not be up to our tasks, potential implementation pitfalls, and other suggestions and comments.

@vitenti
Copy link
Collaborator

vitenti commented Mar 7, 2024

Hi @tilmantroester , we have been working on the redesign of two point in the last two meetings and we are using your work here as a source of ideas to the new design. Soon we will have a separate PR branch with our code to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants