Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pytest_collect_file() compatible with pytest 8.1+ #189

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

JAlvarezJarreta
Copy link
Contributor

Checklist

  • Pull request details were added to HISTORY.rst

@rhpvorderman
Copy link
Member

Thanks for the patch!

8.0+ already. When I started it was version 3.0. It seems like they love breaking everyone's stuff every year...

I will put this on my todo list for this week. Looks like python3.7 breaks as well. As that is not supported I will remove support and make sure the CI passes on this one.

@rhpvorderman
Copy link
Member

Looks like a change that was implemented in 7.0.0. Unfortunately I got no deprecation warnings for this one. I will merge this right away and make a separate PR for 3.12 addition and 3.7 removal.

@rhpvorderman rhpvorderman merged commit e8d5df9 into LUMC:develop Mar 4, 2024
10 of 13 checks passed
@JAlvarezJarreta
Copy link
Contributor Author

Yes, pytest seems to be following SQLAlchemy practices on making breaking changes in subversions... 🙈 Thank you for reviewing and adding this so quickly!

@rhpvorderman
Copy link
Member

@JAlvarezJarreta The new version is released on PyPI now. I am sorry it took so long!

@JAlvarezJarreta
Copy link
Contributor Author

Thank you @rhpvorderman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants