Ignore scaling transforms when resizing a orphan AWTGLCanvas. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the canvas has been added to a parent, its GraphicsConfiguration is null, causing the resize event from eg. a setSize to throw an exception on stderr from the AWT thread.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the canvas has been added to a parent, its
GraphicsConfigurationisnull, causing the resize event from eg. asetSizeto throw an exception on stderr from the AWT thread.I'll admit I'm not sure if the size is set correctly with scaling this way (I don't have a system with system UI scaling to test on), and/or whether a resize event is generated when the canvas is added, nor am I sure whether you would argue that I should just set the size of the canvas after I've added it (I currently call
setSizein the constructor of myAWTGLCanvassubclass). I guess I'm saying "feel free to comment", but this is my naïve suggestion.