Extend the AWTGLCanvas context creation interface to allow trying different parameters. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferent parameters.
|
In case it wasn't obvious, by the way, the intention is to let subclasses of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My particular use-case for this is going through different OpenGL versions and see which one sticks.
It introduces the
ContextDataclass to allow passing the context back through an override of thecreateContextmethod in a way that can be extended into the future, and also puts the effectiveGLDatain there.It does perhaps to some extent call into question the role of the
dataandeffectivefields inAWTGLCanvas, but I wanted this change to be backward compatible, for obvious reasons.