LibWeb: Merge NavigationParams' Empty and NullWithError into NullOrError
#2330
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
dlarocque
force-pushed
the
nullorerror
branch
from
e2dcc9b
to
43c5349
Compare
|
Now has conflicts |
To check whether a NavigationParams is null, we have to check whether it's `Empty` or `NullWithError`. Instead, we can merge both of these possible variants into an optional error. If `NullOrError` has no value it's null, otherwise it contains an error message.
dlarocque
force-pushed
the
nullorerror
branch
from
43c5349
to
84f0b4a
Compare
Thanks- conflicts resolved now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check whether a NavigationParams is null, we have to check whether it's
EmptyorNullWithError. Instead, we can merge both of these possible variants into an optionalNullOrError. IfNullOrErrorhas no value it's null, otherwise it contains the error message that is shown to the user when there's a navigation error.