-
-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: Implement ECDH.generateKey #2402
base: master
Are you sure you want to change the base?
Conversation
We probably want in-tree tests for this, see Documentation/Testing.md for how to create them. Once you have one created, you can run an individual LibWeb test with this command:
|
Should I add to EDIT: Looks like it is excluded for being |
That seems fine to me, but I'm not a maintainer. It looks like that only has RSA-OAEP key generation currently but the name definitely implies it should be more generic so... |
On a recent PR I did for AES-GCM (#2143), I just created a separate file |
Welcome @devgianlu ! Note that you do not necessarily need to write your own test if there's a proper WPT test case for it! Using |
063c0a9
to
50d21b5
Compare
50d21b5
to
3d8bbda
Compare
Thanks @gmta! I've looked deeper into the tests situation and it looks this fixes a bunch of stuff in https://wpt.live/WebCryptoAPI/generateKey/successes_ECDH.https.any.html and https://wpt.live/WebCryptoAPI/generateKey/failures_ECDH.https.any.html too, so I've imported those. |
Fixes some tests in https://wpt.live/WebCryptoAPI/derive_bits_keys/pbkdf2.https.any.html?1-1000 by having a working ECDH
generateKey
so that... with wrong (ECDH) key
tests pass.