LibRegex: Moar Optimizer Fixes #2410
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpfard
force-pushed
the
regex-opt-fixes
branch
from
5ea32c6
to
a5f5578
Compare
Repeat's 'offset' field is a bit odd in that it is treated as a negative offset, causing a backwards jump when positive; the optimizer didn't correctly model this behaviour, which caused crashes and misopts when dealing with Repeats. This commit fixes that behaviour.
alimpfard
force-pushed
the
regex-opt-fixes
branch
from
a5f5578
to
e383f52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(WIP)
TODO:
/(?:\d|[e-h]*|\d*|\d|[h-pe-jh-vl-ua-lc-f]){,8}/.test('ulsf0xjtmiwk59zlwy17vjco2uskue')/(?!\d*|[g-ta-r]+|[h-l]|\S|\S|\S){,9}|\S{7,8}|\d|(?<wnvdfimiwd>)|[c-mj-tb-o]*|\s/.test('rjvogg7pm|li4nmct mjb2|pk7s8e0')