feat: update DB creation circuits for generic extraction (Part 2) #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silathdiir
force-pushed
the
generic-extraction-tree-creation
branch
from
b5a75ac
to
8515c8e
Compare
silathdiir
force-pushed
the
generic-extraction-tree-creation
branch
from
0257177
to
7f9cb61
Compare
silathdiir
changed the title
silathdiir
changed the title
nicholas-mainardi
requested changes
Oct 29, 2024
verifiable-db/src/cells_tree/mod.rs
Outdated
|
|
||
| let cell = CellWire::new(b); | ||
| let values_digest = cell.split_values_digest(b); | ||
| let metadata_digest = cell.split_metadata_digest(b); |
There was a problem hiding this comment.
Why not using directly split_and_accumulate methods?
There was a problem hiding this comment.
Fixed in commit ca0a971.
| .chain(empty_hash.elements) | ||
| .chain(iter::once(cell.identifier)) | ||
| let metadata_digests = cell.split_metadata_digest(b); | ||
| let values_digests = cell.split_values_digest(b); |
There was a problem hiding this comment.
Same as above: why not using split_and_accumulate?
There was a problem hiding this comment.
Fixed in commit ca0a971.
There was a problem hiding this comment.
Seems to me that on this file there were no changes in that commit? Only the other related comments seems to be addressed, no?
There was a problem hiding this comment.
Sorry, I missed this fix, just commit in e37e98e.
Co-authored-by: nicholas-mainardi <[email protected]>
…eric-extraction-tree-creation
silathdiir
commented
Nov 1, 2024
| PublicInputs::new( | ||
| &hash.to_targets(), | ||
| &final_digest.to_targets(), | ||
| &digest.individual_vd.to_targets(), |
| PublicInputs::new( | ||
| &node_hash, | ||
| &final_digest.to_targets(), | ||
| &digest.individual_vd.to_targets(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related section Merkle Tree Creation in Generic Extraction document