remove unused deps #400
Merged
remove unused deps #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no idea why the CI is failing |
hackaugusto
force-pushed
the
hack-remove-unused-deps
branch
from
9df4d7e
to
385e912
Compare
|
Probably at least due to this. Careful with cargo-machete, it tends to be quite trigger-happy and ignore tests. |
hackaugusto
force-pushed
the
hack-remove-unused-deps
branch
from
385e912
to
6c9e1bf
Compare
|
Ah, I see. The deps should have been moved to dev-dependencies not removed. Fixed it |
delehef
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran:
to find the unused ones