Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf improvements for all_equal_simd #12

Closed
wants to merge 0 commits into from
Closed

Conversation

smu160
Copy link
Contributor

@smu160 smu160 commented Jul 21, 2024

This is a draft PR to work on #10.

@PaulDotSH
Copy link
Contributor

Libraries should ignore cargo.lock, can you or @LaihoE add it to .gitignore and remove it?

@LaihoE
Copy link
Owner

LaihoE commented Jul 21, 2024

Libraries should ignore cargo.lock, can you or @LaihoE add it to .gitignore and remove it?

done.

@LaihoE
Copy link
Owner

LaihoE commented Jul 21, 2024

Thanks, looks good!. Btw be careful with dropping the n in tests too low as it can cause the simd part to never be run.

@LaihoE
Copy link
Owner

LaihoE commented Jul 21, 2024

I'm currently working on unrolling the position function. Could you add the UNROLL_FACTOR to the lib.rs next to the SIMD_LEN? I think we should have the same UNROLL_FACTOR for all function (at least for now).

@smu160
Copy link
Contributor Author

smu160 commented Jul 21, 2024

I'm currently working on unrolling the position function. Could you add the UNROLL_FACTOR to the lib.rs next to the SIMD_LEN? I think we should have the same UNROLL_FACTOR for all function (at least for now).

Do you want that here or as a hotfix in a separate PR?

@LaihoE
Copy link
Owner

LaihoE commented Jul 21, 2024

I'm currently working on unrolling the position function. Could you add the UNROLL_FACTOR to the lib.rs next to the SIMD_LEN? I think we should have the same UNROLL_FACTOR for all function (at least for now).

Do you want that here or as a hotfix in a separate PR?

just add it to this pr 👍

@LaihoE
Copy link
Owner

LaihoE commented Jul 28, 2024

Looks good, can we merge this?

@smu160
Copy link
Contributor Author

smu160 commented Jul 29, 2024

Hi @LaihoE,

Apologies for the belated reply. I'm going to get this PR ready for review now. I'll post the before/after benchmarks as well.

Thank you!!

@smu160
Copy link
Contributor Author

smu160 commented Jul 29, 2024

This PR is a bit outdated given the new changes. I will create a new PR for running benchmarks and plotting the (criterion) data, first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants