#98 Fixed overriding variables.

[alexanderlazarev0]

def dep_func() -> int:
    return 1

@inject
def some_func(a: int = Depends(dep_func)) -> int:
    return a

print(some_func(a=2)) # 2
print(some_func(2)) # 2

[Lancetnik]

Can you, please, revert docs/ and styles changes to let me check logic only?

[alexanderlazarev0]

Can you, please, revert docs/ and styles changes to let me check logic only?

@Lancetnik reset formatting, I had run ruff format before commit.

[Lancetnik]

Why are you skipping these tests?

[alexanderlazarev0]

I skipped them since they fail (as they should if overriding is supported). You can also delete them.

[Lancetnik]

But they should works. Your function signature should be accumulation of the function and all dependencies signature

So,

def dep(a): ...

def another_dep(a, b): ...

def func(a, c, dep1 = Depends(dep1), dep2 = Depends(another_dep)): ...

Has (a, b, c) signature

In my opinion, your test test_override_depends_with_by_passing_positional doesn't look correctly due the function has () - empty signature

I think, we should allow overrides dependencies by explicit keyword overriding only

[alexanderlazarev0]

Okay just so we are clear we should allow:

def dep(a: int) -> int:
    return a + 1

@inject
def func(b: int = Depends(dep)):
    return b

func(a=3) # 4
func(b=3) # 3
func(3) # ValidationError

Although in this case func will still have signature (a,) and we are passing (b,)?

From what I can tell, one should allow both signatures -> overloading. I don't see another way to fix #98.

This will come with the side effect that with deeper nesting, for example:

def dep_1_1(d): ...

def dep_1_2(e): ...

@inject
def dep_1(b = Depends(dep_1_1), c = Depends(dep_1_2)): ...

@inject
def func(a = Depends(dep_1)): ...

One would need to allow the signatures : [(a),(b, c), (d, c), (b, e), (d, e)], so the number of signatures will grow "exponentially".

Unless I am misunderstanding your comment.

[Lancetnik]

Nope, we don't create a new signature for each depends, we are including it to the original one, so for your last case signature will be (d, e) only.

I think, we should works this way:

def dep(a: int) -> int:
    return a + 1

@inject
def func(b: int = Depends(dep)):
    return b

func(a=3) # 4
func(b=3) # 3
func(3)     # 4 - the same with `a=3` due our real signature is `(a,)`