Add named assets and SRI hashes to assets #5720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
[ci skip] [skip ci]
[ci skip] [skip ci]
pxpm
force-pushed
the
next
branch
2 times, most recently
from
0cffae1 to
8ece6d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Previously backpack downloaded the assets without validating if the files had the correct hash. This has the potential issue that if the files where somewhat manipulated on the cdn servers, we didn't had a way to validate their integrity.
In addition to that, assets are now mapped. This allow us to push update to assets without having to change the files.
AFTER - What is happening after this PR?
All assets are mapped to corresponding strings, and contain a SRI hash for file integrity validation
Is it a breaking change?
No, since the previous
@basset(url)still work as before.