Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new options to enable client configuration from laravel config file #8

Closed
wants to merge 3 commits into from

Conversation

mahasadhu
Copy link
Contributor

Instead of manually type the client configuration in the view, we can set the configuration directly from the laravel config file. List of configuration can be seen here
https://github.com/Studio-42/elFinder/wiki/Client-configuration-options-2.1#contents


@tabacitu I'm not sure whether I should make this PR here or at https://github.com/barryvdh/laravel-elfinder . Just close this PR if you think I should make the PR at laravel-elfinder repo

@tabacitu
Copy link
Member

Both actually 😅

If they merge it we need to do the same too - since we've basically overwritten some of their files.

So let's keep this open at least until there's a resolution there.

Thanks. Cheers!

@tabacitu tabacitu added the enhancement New feature or request label Sep 19, 2020
@mahasadhu
Copy link
Contributor Author

@tabacitu okay I just submitted a PR to the laravel-elfinder repo

I've also push small changes to prevent json malformed

@promatik
Copy link
Contributor

Hi everyone 🙌

We're here waiting for barryvdh/laravel-elfinder#289 ...
I'm not sure if Barry will ever merge it, laravel-elfinder looks like it's frozen.

@tabacitu for now I'll close this one, if I'm wrong please re-open 🙌

If more people ever needs this kind of configurations please let us know here in this thread and we may re-think about merging it (before Barry on laravel-elfinder).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants